Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to symfony 7 compatibility #289

Closed
wants to merge 1 commit into from
Closed

Upgrade to symfony 7 compatibility #289

wants to merge 1 commit into from

Conversation

tomglvng
Copy link
Collaborator

No description provided.

@tomglvng tomglvng self-assigned this Sep 20, 2024
Copy link

@lasdou lasdou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not going directly php 8.3 as php 8.2 active support will end in 3 months 31 Dec 2024 ?

"psr/http-message": "^1.0",
"psr/http-client": "^1.0",
"psr/http-factory": "^1.0",
"psr/http-message-implementation": "^1.0|^2.0",
"php-http/httplug": "^2.0",
"php-http/discovery": "^1.6",
"php-http/multipart-stream-builder": "^1.0",
"symfony/options-resolver": "^5.4|^6.0|^7.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this break the compatibility with versions older than 7.0?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, how does this bring compatibility with Symfony 7? It seems it was already in the list, so I don't see what it adds.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symfony 7 needs at least PHP 8.2

@@ -20,19 +20,19 @@
}
},
"require": {
"php": ">=8.0",
"php": ">=8.2",
"psr/http-message": "^1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem in our Slack conversation seems more related to this restriction on psr/http-message where they need 2.0 or above.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I need to upgrade psr/http-message

@tomglvng
Copy link
Collaborator Author

Why not going directly php 8.3 as php 8.2 active support will end in 3 months 31 Dec 2024 ?

We should always be compatible with most people without compromising security : the last PHP maintained PHP version is 8.2 until the 1st of January 2025

@tomglvng
Copy link
Collaborator Author

I close this PR: we only need to upgrade PHP to 8.2 (Symfony is still maintained until 1st of January 2025)
See my new PR --> #290

@tomglvng tomglvng closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants