Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Schema version was not propagated to groups #141

Merged
merged 1 commit into from
May 20, 2014
Merged

[Java] Schema version was not propagated to groups #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions main/java/uk/co/real_logic/sbe/generation/java/JavaGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ private void generateGroupClassHeader(final StringBuilder sb,
indent + " {\n" +
indent + " this.parentMessage = parentMessage;\n" +
indent + " this.buffer = buffer;\n" +
indent + " actingVersion = SCHEMA_VERSION;\n" +
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason why parent version would differ from SCHEMA_VERSION in such a case. This is why I did not retrieve parentMessage.actingVersion. One might also want to create a group without a properly initialized parent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is a good catch.

indent + " dimensions.wrap(buffer, parentMessage.limit(), actingVersion);\n" +
indent + " dimensions.numInGroup((%2$s)count);\n" +
indent + " dimensions.blockLength((%3$s)%4$d);\n" +
Expand Down