[Java] Schema version was not propagated to groups #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version was always set to 0 when encoding. Preventing to retrieve field values while encoding (to set values within Object field for instance)
| @@ -241,6 +241,7 @@ private void generateGroupClassHeader(final StringBuilder sb, | |||
| indent + " {\n" + | |||
| indent + " this.parentMessage = parentMessage;\n" + | |||
| indent + " this.buffer = buffer;\n" + | |||
| indent + " actingVersion = SCHEMA_VERSION;\n" + | |||
There was a problem hiding this comment.
I see no reason why parent version would differ from SCHEMA_VERSION in such a case. This is why I did not retrieve parentMessage.actingVersion. One might also want to create a group without a properly initialized parent.
There was a problem hiding this comment.
Thanks this is a good catch.
mjpt777
added a commit
that referenced
this pull request
May 20, 2014
[Java] Schema version was not propagated to groups
|
Useful for symmetry but the actingVersion is not encoded within the repeating group so should make no noticeable difference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version was always set to 0 when encoding. Preventing to retrieve field values while encoding (to set values within Object field for instance)