chore(button): S2 fast follows fixes #5174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 294fb77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsChromebutton permalinktest-basic
Firefoxbutton permalinktest-basic
|
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Pull Request Test Coverage Report for Build 14008296000Details
💛 - Coveralls |
…e/spectrum-web-components into rajdeep/button-fast-follows
|
@Rajdeepc is this ready for review? |
Rajdeepc
changed the title
Not yet! We are addressing change requests from design here. When its ready for review the tag will be there. |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the Button component's API to enhance clarity and maintainability by introducing logic that allows static-color properties and variant types to coexist. Previously, the API did not account for scenarios where both variant and static-color properties were used together, leading to inconsistencies in the contract. This update ensures proper handling of Spectrum 2 Button fast-follow changes related to static color properties.
Proposal
. API Coexistence
variantandstatic-colorattributes can be used togethervariantdetermines the semantic style (accent, primary, secondary, negative)static-colordetermines the color (white, black)Design Spec
https://spectrum.adobe.com/page/button/#Static-color
Related Issue
How has this been tested?
Static Black Spectrum 2
Static White Spectrum 2
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.