build: remove the build task from postinstall (#5016)

* build: remove the build task from postinstall

* chore: add build to circleci downstream

---------

Co-authored-by: Casey Eickhoff <[email protected]>

Author: castastrophe

.circleci/config.yml

@@ -33,6 +33,9 @@ commands:
                   command: |
                       corepack enable
                       yarn --immutable
+            - run:
+                  name: Build the project
+                  command: yarn build
 
             - save_cache:
                   paths:

.github/actions/setup-job/action.yml

@@ -17,3 +17,7 @@ runs:
         - name: Install dependencies
           shell: bash
           run: yarn --immutable
+
+        - name: Build the project
+          shell: bash
+          run: yarn build

.husky/pre-commit

@@ -1,13 +1,15 @@
-STAGED_FILES_TO_LINT=$(git diff --name-only --cached --diff-filter=d -- "*.ts" "*.js")
-STAGED_FILES_TO_ANALYZE=$(git diff --name-only --cached --diff-filter=d -- "{packages,tools}/*/src/**/!(*.css).ts")
-STAGED_CSS_FILES=$(git diff --name-only --cached --diff-filter=d -- "{packages,tools}/**/*.css")
-VERSION_FILE=$(dirname "$0")/../tools/base/src/version.js
+bash << EOF
+    STAGED_FILES_TO_LINT=$(git diff --name-only --cached --diff-filter=d -- "*.ts" "*.js")
+    STAGED_FILES_TO_ANALYZE=$(git diff --name-only --cached --diff-filter=d -- "{packages,tools}/*/src/**/!(*.css).ts")
+    STAGED_CSS_FILES=$(git diff --name-only --cached --diff-filter=d -- "{packages,tools}/**/*.css")
+    VERSION_FILE=$(dirname "$0")/../tools/base/src/version.js
 
-[[ -z "$STAGED_FILES_TO_LINT" ]] || yarn eslint -f pretty $STAGED_FILES_TO_LINT
-[[ -z "$STAGED_FILES_TO_ANALYZE" ]] || yarn lit-analyzer $STAGED_FILES_TO_ANALYZE
-[[ -z "$STAGED_CSS_FILES" ]] || yarn stylelint $STAGED_CSS_FILES
+    [[ -z "$STAGED_FILES_TO_LINT" ]] || yarn eslint -f pretty $STAGED_FILES_TO_LINT
+    [[ -z "$STAGED_FILES_TO_ANALYZE" ]] || yarn lit-analyzer $STAGED_FILES_TO_ANALYZE
+    [[ -z "$STAGED_CSS_FILES" ]] || yarn stylelint $STAGED_CSS_FILES
 
-yarn pretty-quick --staged
+    yarn pretty-quick --staged
 
-yarn genversion --es6 --semi $VERSION_FILE
-git add $VERSION_FILE
+    yarn genversion --es6 --semi $VERSION_FILE
+    git add $VERSION_FILE
+EOF

RELEASE_PROCESS.md

@@ -5,7 +5,7 @@ Users with permissions in the `@spectrum-web-components` organization on NPM can
 1. Merge all pull requests to be included in the release and wait for the `main` branch to show that it has completed the required CI jobs.
 2. `git checkout main && git fetch && git pull && git clean -dfX`
 3. Run `nvm use` assumes a Node Version Manager install, and confirm your on an operable version of Node.
-4. `yarn install`
+4. `yarn install && yarn build` to install all dependencies and build the pre-processed assets for publication.
 5. `npm whoami` ensure that you are logged in with the user account for the public NPM registry
 6. `yarn changeset-publish`
 7. Scan the version summary for any unexpected changes.
@@ -25,7 +25,7 @@ The docs site will publish automatically if the `#publish` string is included in
 
 If publishing fails with an error, check the [list of tags](https://github.com/adobe/spectrum-web-components/tags) to see if new tags have been released for your publishing attempt. If they were, run `yarn changeset-publish` again.
 
-### Publishing the docs site manually
+## Publishing the docs site manually
 
 Navigate to SWC's [Actions](https://github.com/adobe/spectrum-web-components/actions) and click the `Build & publish site` link under the _Workflows_ heading.
 

package.json

@@ -23,7 +23,7 @@
         "build:types": "wireit",
         "build:watch": "wireit",
         "changeset-snapshot-publish": "yarn prepublishOnly && yarn changeset version --snapshot && yarn lint:versions --fix && yarn changeset publish --no-git-tag --tag snapshot && yarn create-git-tag && yarn postpublish",
-        "changeset-publish": "yarn prepublishOnly && yarn changeset version && yarn install && yarn lint:versions --fix && yarn changeset publish --no-git-tag && yarn push-to-remote && yarn create-git-tag && yarn postpublish",
+        "changeset-publish": "yarn changeset version && yarn install && yarn prepublishOnly && yarn lint:versions --fix && yarn changeset publish --no-git-tag && yarn push-to-remote && yarn create-git-tag && yarn postpublish",
         "chromatic": "chromatic --build-script-name storybook:build # note that --project-token must be set in your env variables",
         "create-git-tag": "node --no-warnings tasks/create-git-tag.js",
         "custom-element-json": "node tasks/custom-element-json.js",
@@ -35,8 +35,8 @@
         "docs:review": "alex packages/**/*.md",
         "docs:start": "yarn workspace documentation serve --watch",
         "find": "test -f custom-elements.json",
+        "format:css": "yarn lint:css --fix && pretty-quick --pattern \"{packages,tools}/**/*.css\"",
         "gen-react-wrapper": "node ./tasks/gen-react-wrapper.js",
-        "get-ready": "yarn build",
         "icons": "wireit",
         "icons:ui": "wireit",
         "icons:workflow": "wireit",
@@ -50,13 +50,14 @@
         "new-package": "cd projects/templates && plop",
         "postcustom-element-json": "node ./tasks/run-check-cem.js",
         "postdocs:analyze": "node ./scripts/add-custom-properties.js --src=\"projects/documentation/custom-elements.json\"",
-        "postinstall": "husky && patch-package && yarn get-ready",
+        "postinstall": "husky || true && patch-package",
         "postpublish": "yarn prepublish:react && yarn publish:react && yarn postpublish:react",
         "postpublish:react": "git reset --hard HEAD^ && git prune && rimraf react",
         "precustom-element-json": "node tasks/remove-custom-elements-json.js",
         "preeleventy": "yarn docs:analyze",
-        "prepublishOnly": "rimraf react && yarn get-ready && yarn custom-element-json && yarn verify-build-artifacts && yarn build:confirm",
-        "prepare": "husky",
+        "prepack": "pinst --disable",
+        "postpack": "pinst --enable",
+        "prepublishOnly": "rimraf react && yarn build && yarn custom-element-json && yarn verify-build-artifacts && yarn build:confirm",
         "prepublish:react": "yarn build:react && sed -i \"\" \"s/react/# react/g\" .gitignore && git commit -am \"Commit React Wrappers\" --no-verify",
         "prestorybook": "wireit",
         "prestorybook:build": "cem analyze --outdir storybook/",
@@ -179,10 +180,11 @@
         "node-fetch": "^3.1.0",
         "npm-run-all2": "^6.0.0",
         "patch-package": "^8.0.0",
+        "pinst": "^3.0.0",
         "prettier": "^3.0.0",
         "prettier-plugin-package": "^1.3.0",
         "pretty-bytes": "^6.1.1",
-        "pretty-quick": "^4.0.0",
+        "pretty-quick": "^4.1.1",
         "re-template-tag": "^2.0.1",
         "react": "^18.2.0",
         "react-dom": "^18.2.0",
@@ -381,7 +383,7 @@
             ]
         },
         "process-spectrum": {
-            "command": "node ./scripts/spectrum-vars.js && node ./tasks/process-spectrum.js && node ./scripts/generate-tokens.js && yarn lint:css --fix && pretty-quick --pattern \"{packages,tools}/**/*.css\"",
+            "command": "node ./scripts/spectrum-vars.js && node ./tasks/process-spectrum.js && node ./scripts/generate-tokens.js && yarn format:css",
             "files": [
                 "tasks/process-spectrum.js",
                 "packages/**/spectrum-config.js",

renovate.json

@@ -4,15 +4,16 @@
     "timezone": "America/Los_Angeles",
     "schedule": ["after 12pm on thursday"],
     "semanticCommitScope": "",
-    "allowedCommands": [
-        "^yarn build$",
-        "^yarn lint",
-        "^yarn test$",
-        "^yarn constraints",
-        "^yarn install"
-    ],
-    "postUpgradeTasks": {
-        "commands": ["yarn build", "yarn constraints --fix", "yarn install"],
-        "executionMode": "branch"
-    }
+    "labels": ["dependencies"],
+    "packageRules": [
+        {
+            "matchPackageNames": ["@spectrum-css/*"],
+            "labels": ["Spectrum CSS"],
+            "postUpgradeTasks": {
+                "commands": ["yarn build"],
+                "executionMode": "branch",
+                "fileFilters": ["packages/*/src/*.css", "tools/**/*.css"]
+            }
+        }
+    ]
 }

yarn.lock

@@ -283,10 +283,11 @@ __metadata:
     node-fetch: "npm:^3.1.0"
     npm-run-all2: "npm:^6.0.0"
     patch-package: "npm:^8.0.0"
+    pinst: "npm:^3.0.0"
     prettier: "npm:^3.0.0"
     prettier-plugin-package: "npm:^1.3.0"
     pretty-bytes: "npm:^6.1.1"
-    pretty-quick: "npm:^4.0.0"
+    pretty-quick: "npm:^4.1.1"
     re-template-tag: "npm:^2.0.1"
     react: "npm:^18.2.0"
     react-dom: "npm:^18.2.0"
@@ -20668,7 +20669,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"ignore@npm:^5.0.0, ignore@npm:^5.1.4, ignore@npm:^5.2.0, ignore@npm:^5.2.4, ignore@npm:^5.3.0, ignore@npm:^5.3.1":
+"ignore@npm:^5.0.0, ignore@npm:^5.1.4, ignore@npm:^5.2.0, ignore@npm:^5.2.4, ignore@npm:^5.3.1":
   version: 5.3.1
   resolution: "ignore@npm:5.3.1"
   checksum: 10c0/703f7f45ffb2a27fb2c5a8db0c32e7dee66b33a225d28e8db4e1be6474795f606686a6e3bcc50e1aa12f2042db4c9d4a7d60af3250511de74620fbed052ea4cd
@@ -27450,10 +27451,10 @@ __metadata:
   languageName: node
   linkType: hard
 
-"picomatch@npm:^3.0.1":
-  version: 3.0.1
-  resolution: "picomatch@npm:3.0.1"
-  checksum: 10c0/70ec738569f1864658378b7abdab8939d15dae0718c1df994eae3346fd33daf6a3c1ff4e0c1a0cd1e2c0319130985b63a2cff34d192f2f2acbb78aca76111736
+"picomatch@npm:^4.0.2":
+  version: 4.0.2
+  resolution: "picomatch@npm:4.0.2"
+  checksum: 10c0/7c51f3ad2bb42c776f49ebf964c644958158be30d0a510efd5a395e8d49cb5acfed5b82c0c5b365523ce18e6ab85013c9ebe574f60305892ec3fa8eee8304ccc
   languageName: node
   linkType: hard
 
@@ -27534,6 +27535,15 @@ __metadata:
   languageName: node
   linkType: hard
 
+"pinst@npm:^3.0.0":
+  version: 3.0.0
+  resolution: "pinst@npm:3.0.0"
+  bin:
+    pinst: bin.js
+  checksum: 10c0/abb1ed62ea2acb2207a7a860715bdb26ecbde74ede8fad5f6200194f3e22db25e2b7a49af05e5cc7fc05384709c651e0000323f0077d7239060c4b68c8acd428
+  languageName: node
+  linkType: hard
+
 "pirates@npm:^4.0.4, pirates@npm:^4.0.6":
   version: 4.0.6
   resolution: "pirates@npm:4.0.6"
@@ -28724,22 +28734,22 @@ __metadata:
   languageName: node
   linkType: hard
 
-"pretty-quick@npm:^4.0.0":
-  version: 4.0.0
-  resolution: "pretty-quick@npm:4.0.0"
+"pretty-quick@npm:^4.1.1":
+  version: 4.1.1
+  resolution: "pretty-quick@npm:4.1.1"
   dependencies:
-    execa: "npm:^5.1.1"
     find-up: "npm:^5.0.0"
-    ignore: "npm:^5.3.0"
+    ignore: "npm:^7.0.3"
     mri: "npm:^1.2.0"
-    picocolors: "npm:^1.0.0"
-    picomatch: "npm:^3.0.1"
-    tslib: "npm:^2.6.2"
+    picocolors: "npm:^1.1.1"
+    picomatch: "npm:^4.0.2"
+    tinyexec: "npm:^0.3.2"
+    tslib: "npm:^2.8.1"
   peerDependencies:
     prettier: ^3.0.0
   bin:
     pretty-quick: lib/cli.mjs
-  checksum: 10c0/f92f5f6a4c7b8e5c87c405d09f883e49d538bbb117a8d8623102f25900fc2d4617314d30c5320c6278fa9ac2da15e74076e08319a797a5d0028b43d6c5da591b
+  checksum: 10c0/c0362aff7d7679f58c044891047e7bbb03d461543aa30b1c57fef9400fa8c4d1daef4aa2b146a9c9072ce050c60860a88eb64b3fd722826dc56616f7cd1d6011
   languageName: node
   linkType: hard
 
@@ -32772,7 +32782,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"tinyexec@npm:^0.3.0":
+"tinyexec@npm:^0.3.0, tinyexec@npm:^0.3.2":
   version: 0.3.2
   resolution: "tinyexec@npm:0.3.2"
   checksum: 10c0/3efbf791a911be0bf0821eab37a3445c2ba07acc1522b1fa84ae1e55f10425076f1290f680286345ed919549ad67527d07281f1c19d584df3b74326909eb1f90
@@ -33069,7 +33079,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"tslib@npm:2, tslib@npm:^2.0.0, tslib@npm:^2.0.1, tslib@npm:^2.0.3, tslib@npm:^2.1.0, tslib@npm:^2.3.1, tslib@npm:^2.4.0, tslib@npm:^2.6.2":
+"tslib@npm:2, tslib@npm:^2.0.0, tslib@npm:^2.0.1, tslib@npm:^2.0.3, tslib@npm:^2.1.0, tslib@npm:^2.3.1, tslib@npm:^2.4.0, tslib@npm:^2.6.2, tslib@npm:^2.8.1":
   version: 2.8.1
   resolution: "tslib@npm:2.8.1"
   checksum: 10c0/9c4759110a19c53f992d9aae23aac5ced636e99887b51b9e61def52611732872ff7668757d4e4c61f19691e36f4da981cd9485e869b4a7408d689f6bf1f14e62