chore(number-field, textfield): update to latest s2 fast follows #5157
+327
−248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ed02bbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsChromenumber-field permalinkbasic-test
textfield permalinktest-basic
Firefoxnumber-field permalinkbasic-test
textfield permalinktest-basic
|
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Pull Request Test Coverage Report for Build 14127221516Details
💛 - Coveralls |
|
If you can confirm this change is expected: https://53af3add8e6f3e8f0d63c61c310f1e98--spectrumwc.netlify.app/review/#TextfieldStories/quiet.png |
As Expected: |
TarunAdobe
changed the title
TarunAdobe
force-pushed
the
ttomar/number-field
branch
from
d1f7665 to
c614f3e
Compare
|
We can merge this once it is cleared from design review |
TarunAdobe
force-pushed
the
ttomar/number-field
branch
from
aaa2e10 to
6d1538d
Compare
caseyisonit
added
Component: Textfield
Component: Number Field
ready-for-review
fast-follow
|
@Rajdeepc @TarunAdobe Has design reviewed and signed off on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update number field to 7.1.2 and text field to 8.1.1
Related issue(s)
Motivation and context
How has this been tested?
Test case 1
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.