-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP | feat: update css to latest #5142
base: main
Are you sure you want to change the base?
Conversation
|
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
1987d3a
to
d74a21d
Compare
eaebcbe
to
8dd0fe4
Compare
254702b
to
61e85fb
Compare
1043476
to
bbcbb23
Compare
36b5cba
to
8ff4a13
Compare
8ff4a13
to
04a9805
Compare
Description
This is a full upgrade of all packages to use the latest published CSS from the @spectrum-css project.
Why update everything at once?
It is often easier to see changes in components that influence one-another (i.e., --mod passthrough styles from parent components) if we bump all components together.
That does not mean that all components need to be merged via this PR but rather, that all components can be viewed in unison via this PR.
Related issue(s)
Most related issues exist in Jira but this is a nice view of the scope of updates we are still needing in order to be up-to-date with the latest fast-follows design updates and CSS theming optimizations (these optimizations have removed hundreds of extemporaneous custom properties.
How has this been tested?
Strongly recommend relying heavily on the VRT results and sanity-checking the Storybook pages by clicking through some of the more problematic components (especially those with nested SWC components or styles from multiple CSS packages).
Strongly suggest design review this Storybook for their most important components and validate the S2 versions are as they wish. This PR is up-to-date with the latest fast-follows that have been merged.
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.