Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread types through in error messages #66

Conversation

parsonsmatt
Copy link

This PR keeps track of the types that are being acquired with getters. I'm going to post a new error message once I've done it on our repo.

Resolves #63

@parsonsmatt
Copy link
Author

Eh, this doesn't seem to do much to help for the specific case I was working on.

@stepcut
Copy link
Member

stepcut commented Jul 17, 2018

@parsonsmatt Even though it did not help your specific case, do you still believe it is worth pulling?

@parsonsmatt
Copy link
Author

I'm not sure when this will actually fire, to be honest. I expected that the decoding would keep the context of what type we're in when we go to do another type. eg:

data T = T { x :: X }
data X = X  { a :: A }
data A = A { foo :: Text }

Would display something like:

failed to decode `Text`. Context: A, X, T

But it doesn't do this. So I'm unsure what this actually does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error messages
2 participants