Implement typeable-based default #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we ok with dropping ghc-7.8 support? I am. The travis build is missing typeable instances. |
|
Fine by me. |
|
If we're going to only support >=7.10 then I'll submit a PR without the CPP :) |
|
We should keep 7.10 - some people still use the ghcjs version based on it. |
|
OK, it passes CI on GHC >=7.10 :) I regenerated the travis.yml with newer point versions as well (and the newer script), can revert that one if y'all want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a
Typeable-based default implementation oferrorTypeNamefor better error messages. This implementation uses CPP to preserve GHC < 7.2 compatibility.Resolves #64