Batching triples.py and symplectics.py #563
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apchytr
commented
Mar 7, 2025
apchytr
commented
Mar 11, 2025
| # ~~~~~~~~~ | ||
|
|
||
|
|
||
| def compute_batch_size(*args) -> tuple[tuple[int, ...] | None, int]: |
There was a problem hiding this comment.
Can probably replace with broadcast_arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The first step toward our general batching epic is enabling batching the methods that generate our built-in CircuitComponents i.e.
triples.pyandsymplectics.py.Merge Backend stack and broadcast to before this PR
TODOs:
gdm_state_Abcandsauron_state_Abc. Both make use ofcomplex_gaussian_integral_2and so are blocked until that method is updatedDescription of the Change: Introduced the
triples_batched.pyfile. Updatedsymplectics.py. Misc changes.Benefits: Arbitrary batch dim triples and symplectics