Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend stack and broadcast to #561

Merged
merged 14 commits into from
Mar 7, 2025
Merged

Backend stack and broadcast to #561

merged 14 commits into from
Mar 7, 2025

Conversation

apchytr
Copy link
Collaborator

@apchytr apchytr commented Feb 25, 2025

Context: Implementing backend methods for future use. E.g. triples batches and new PolyExpAnsatz

Merge before: Batching triples.py and symplectics.py

Description of the Change: Implement stack and broadcast_to in the backend. Also cleaned up math.allclose

@apchytr apchytr added the no changelog Pull request does not require a CHANGELOG entry label Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (e17bc9b) to head (56d43a2).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #561   +/-   ##
========================================
  Coverage    90.17%   90.17%           
========================================
  Files          102      102           
  Lines         6175     6180    +5     
========================================
+ Hits          5568     5573    +5     
  Misses         607      607           
Files with missing lines Coverage Δ
mrmustard/math/backend_manager.py 98.25% <100.00%> (+0.02%) ⬆️
mrmustard/math/backend_numpy.py 100.00% <ø> (ø)
mrmustard/math/backend_tensorflow.py 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e17bc9b...56d43a2. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apchytr apchytr changed the title Backend stack Backend stack and broadcast to Feb 26, 2025
Copy link
Collaborator

@aplund aplund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine.

@apchytr apchytr merged commit e58f17d into develop Mar 7, 2025
12 checks passed
@apchytr apchytr deleted the npStack branch March 7, 2025 13:44
ziofil pushed a commit that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Pull request does not require a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants