feat, test: return fixed parameters for non-Unimind addresses (#519)

* feat: return fixed parameters for non-unimind addresses * test: update tests
Uniswap · Feb 13, 2025 · 73682be · 73682be
1 parent 43b0fc2
commit 73682be
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 9 deletions.
diff --git a/lib/handlers/get-unimind/handler.ts b/lib/handlers/get-unimind/handler.ts
@@ -7,7 +7,7 @@ import { Unit } from 'aws-embedded-metrics'
 import { APIGatewayProxyEvent, APIGatewayProxyResult, Context } from 'aws-lambda'
 import { metrics } from '../../util/metrics'
 import { UnimindQueryParams, unimindQueryParamsSchema } from './schema'
-import { DEFAULT_UNIMIND_PARAMETERS } from '../../util/constants'
+import { DEFAULT_UNIMIND_PARAMETERS, PUBLIC_UNIMIND_PARAMETERS, UNIMIND_DEV_SWAPPER_ADDRESS } from '../../util/constants'
 
 type UnimindResponse = {
   pi: number
@@ -20,9 +20,8 @@ export class GetUnimindHandler extends APIGLambdaHandler<ContainerInjected, Requ
   ): Promise<Response<UnimindResponse> | ErrorResponse> {
     const { containerInjected, requestQueryParams } = params
     const { quoteMetadataRepository, unimindParametersRepository } = containerInjected
-
     try {
-      const { logOnly, ...quoteMetadataFields } = requestQueryParams
+      const { logOnly, swapper, ...quoteMetadataFields } = requestQueryParams
       const quoteMetadata = {
         ...quoteMetadataFields,
         route: requestQueryParams.route ? JSON.parse(requestQueryParams.route) : undefined
@@ -38,6 +37,12 @@ export class GetUnimindHandler extends APIGLambdaHandler<ContainerInjected, Requ
           }
         }
       }
+      if (!swapper || swapper != UNIMIND_DEV_SWAPPER_ADDRESS) {
+        return {
+            statusCode: 200,
+            body: PUBLIC_UNIMIND_PARAMETERS
+        }
+      }
 
       let [, unimindParameters] = await Promise.all([
         quoteMetadataRepository.put(quoteMetadata),

diff --git a/lib/handlers/get-unimind/schema/index.ts b/lib/handlers/get-unimind/schema/index.ts
@@ -42,11 +42,13 @@ export const unimindQueryParamsSchema = Joi.object({
   logOnly: Joi.boolean().optional()
     .truthy('true')
     .falsy('false')
-    .sensitive()
+    .sensitive(),
     // All other values are rejected for a 400 error
+  swapper: Joi.string().optional()
 })
 
 export type UnimindQueryParams = Omit<QuoteMetadata, 'route'> & {
   route: string, // route is now a JSON string to be used as a GET query param
-  logOnly?: boolean
+  logOnly?: boolean,
+  swapper?: string
 }
diff --git a/lib/util/constants.ts b/lib/util/constants.ts
@@ -27,4 +27,9 @@ export const DYNAMO_BATCH_WRITE_MAX = 25
 export const DEFAULT_UNIMIND_PARAMETERS = {
   pi: 5,
   tau: 5
+}
+export const UNIMIND_DEV_SWAPPER_ADDRESS = '0x2b813964306D8F12bdaB5504073a52e5802f049D'
+export const PUBLIC_UNIMIND_PARAMETERS = {
+  pi: 8,
+  tau: 5
 }
diff --git a/test/unit/handlers/get-unimind/get-unimind.test.ts b/test/unit/handlers/get-unimind/get-unimind.test.ts
@@ -5,6 +5,7 @@ import { GetUnimindHandler } from '../../../../lib/handlers/get-unimind/handler'
 import { QuoteMetadataRepository } from '../../../../lib/repositories/quote-metadata-repository'
 import { UnimindParametersRepository } from '../../../../lib/repositories/unimind-parameters-repository'
 import { ErrorCode } from '../../../../lib/handlers/base'
+import { UNIMIND_DEV_SWAPPER_ADDRESS } from '../../../../lib/util/constants'
 
 const SAMPLE_ROUTE = {
   quote: "1234",
@@ -53,6 +54,10 @@ describe('Testing get unimind handler', () => {
       priceImpact: 0.01,
       route: STRINGIFIED_ROUTE,
     }
+    const quoteQueryParams = {
+      ...quoteMetadata,
+      swapper: UNIMIND_DEV_SWAPPER_ADDRESS
+    }
 
     mockUnimindParametersRepo.getByPair.mockResolvedValue({
       pair: 'ETH-USDC',
@@ -62,7 +67,7 @@ describe('Testing get unimind handler', () => {
 
     const response = await getUnimindHandler.handler(
       {
-        queryStringParameters: quoteMetadata,
+        queryStringParameters: quoteQueryParams,
         requestContext: {
           requestId: 'test-request-id'
         }
@@ -91,12 +96,16 @@ describe('Testing get unimind handler', () => {
       pair: 'ALAN-LEN',
       route: STRINGIFIED_ROUTE,
     }
+    const quoteQueryParams = {
+      ...quoteMetadata,
+      swapper: UNIMIND_DEV_SWAPPER_ADDRESS
+    }
 
     mockUnimindParametersRepo.getByPair.mockResolvedValue(undefined)
 
     const response = await getUnimindHandler.handler(
       {
-        queryStringParameters: quoteMetadata,
+        queryStringParameters: quoteQueryParams,
         requestContext: {
           requestId: 'test-request-id'
         }
@@ -117,7 +126,7 @@ describe('Testing get unimind handler', () => {
     })
   })
 
-  it('Returns empty parameters when expectParams is false', async () => {
+  it('Returns empty parameters when logOnly is true', async () => {
     const quoteMetadata = {
       quoteId: 'this-should-work',
       referencePrice: '100',
@@ -247,12 +256,16 @@ describe('Testing get unimind handler', () => {
       priceImpact: 0.01,
       route: STRINGIFIED_ROUTE,
     }
+    const quoteQueryParams = {
+      ...quoteMetadata,
+      swapper: UNIMIND_DEV_SWAPPER_ADDRESS
+    }
 
     mockQuoteMetadataRepo.put.mockRejectedValue(new Error('DB Error'))
 
     const response = await getUnimindHandler.handler(
       {
-        queryStringParameters: quoteMetadata,
+        queryStringParameters: quoteQueryParams,
         requestContext: {
           requestId: 'test-request-id-repo-error'
         }
@@ -394,6 +407,7 @@ describe('Testing get unimind handler', () => {
       priceImpact: 0.01,
       pair: 'ETH-USDC',
       route: STRINGIFIED_ROUTE,
+      swapper: UNIMIND_DEV_SWAPPER_ADDRESS
     }
 
     const response = await getUnimindHandler.handler(
@@ -417,6 +431,7 @@ describe('Testing get unimind handler', () => {
       referencePrice: '4221.21',
       priceImpact: 0.01,
       pair: 'ETH-USDC',
+      swapper: UNIMIND_DEV_SWAPPER_ADDRESS,
       blockNumber: 1234,
       // missing route
     }
@@ -440,6 +455,7 @@ describe('Testing get unimind handler', () => {
       referencePrice: '4221.21',
       priceImpact: 0.01,
       pair: 'ETH-USDC',
+      swapper: UNIMIND_DEV_SWAPPER_ADDRESS,
       // missing blockNumber
       route: STRINGIFIED_ROUTE,
     }