feat, test: store and log classic blockNumber (#522)

* feat: store and log classic blockNumber * test: blockNumber optional * feat: add blockNumber to orders table
Uniswap · Feb 10, 2025 · 43b0fc2 · 43b0fc2
1 parent 8df99f8
commit 43b0fc2
Show file tree

Hide file tree

Showing 9 changed files with 34 additions and 1 deletion.
diff --git a/lib/entities/Order.ts b/lib/entities/Order.ts
@@ -88,6 +88,7 @@ export type SharedXOrderEntity = {
   settledAmounts?: SettledAmount[]
   referencePrice?: string
   priceImpact?: number
+  blockNumber?: number
   route?: Route
   pair?: string
 }

diff --git a/lib/handlers/get-unimind/schema/index.ts b/lib/handlers/get-unimind/schema/index.ts
@@ -20,6 +20,7 @@ export const unimindQueryParamsSchema = Joi.object({
   pair: Joi.string().required(),
   referencePrice: Joi.string().required(),
   priceImpact: Joi.number().required(),
+  blockNumber: Joi.number().optional(),
   route: Joi.string()
     .optional()
     .custom((value, helpers) => {

diff --git a/lib/models/PriorityOrder.ts b/lib/models/PriorityOrder.ts
@@ -63,6 +63,7 @@ export class PriorityOrder extends Order {
       createdAt: this.createdAt,
       referencePrice: quoteMetadata?.referencePrice,
       priceImpact: quoteMetadata?.priceImpact,
+      blockNumber: quoteMetadata?.blockNumber,
       route: quoteMetadata?.route,
       pair: quoteMetadata?.pair,
     }

diff --git a/lib/repositories/dutch-orders-repository.ts b/lib/repositories/dutch-orders-repository.ts
@@ -42,6 +42,7 @@ export class DutchOrdersRepository extends GenericOrdersRepository<string, strin
         cosigner: { type: DYNAMODB_TYPES.STRING },
         referencePrice: { type: DYNAMODB_TYPES.STRING },
         priceImpact: { type: DYNAMODB_TYPES.NUMBER },
+        blockNumber: { type: DYNAMODB_TYPES.NUMBER },
         route: { type: DYNAMODB_TYPES.MAP },
         pair: { type: DYNAMODB_TYPES.STRING },
 

diff --git a/lib/repositories/quote-metadata-repository.ts b/lib/repositories/quote-metadata-repository.ts
@@ -23,6 +23,7 @@ export interface QuoteMetadata {
   quoteId: string
   referencePrice: string
   priceImpact: number
+  blockNumber: number
   route: Route
   pair: string
 }
@@ -54,6 +55,7 @@ export class DynamoQuoteMetadataRepository implements QuoteMetadataRepository {
         referencePrice: { type: DYNAMODB_TYPES.STRING, required: true },
         priceImpact: { type: DYNAMODB_TYPES.NUMBER, required: true },
         pair: {type: DYNAMODB_TYPES.STRING, required: true},
+        blockNumber: {type: DYNAMODB_TYPES.NUMBER, required: false},
         route: {type: DYNAMODB_TYPES.MAP, required: false}
       },
       table,

diff --git a/lib/services/analytics-service.ts b/lib/services/analytics-service.ts
@@ -35,6 +35,7 @@ export class AnalyticsService implements AnalyticsServiceInterface {
       tokenIn: order.input?.token,
       tokenOut: order.outputs[0].token,
       orderType: orderType,
+      blockNumber: order?.blockNumber,
       route: JSON.stringify(order?.route),
     }
 

diff --git a/test/unit/handlers/get-unimind/get-unimind.test.ts b/test/unit/handlers/get-unimind/get-unimind.test.ts
@@ -417,6 +417,7 @@ describe('Testing get unimind handler', () => {
       referencePrice: '4221.21',
       priceImpact: 0.01,
       pair: 'ETH-USDC',
+      blockNumber: 1234,
       // missing route
     }
 
@@ -432,4 +433,27 @@ describe('Testing get unimind handler', () => {
     expect(mockQuoteMetadataRepo.put).toHaveBeenCalledTimes(1)
     expect(mockUnimindParametersRepo.getByPair).toHaveBeenCalledTimes(1)
   })
-}) 
+
+  it('blockNumber is optional', async () => {
+    const quoteMetadata = {
+      quoteId: 'test-quote-id',
+      referencePrice: '4221.21',
+      priceImpact: 0.01,
+      pair: 'ETH-USDC',
+      // missing blockNumber
+      route: STRINGIFIED_ROUTE,
+    }
+
+    const response = await getUnimindHandler.handler(
+      {
+        queryStringParameters: quoteMetadata,
+        requestContext: { requestId: 'test-request-id' }
+      } as any,
+      EVENT_CONTEXT
+    )
+
+    expect(response.statusCode).toBe(200)
+    expect(mockQuoteMetadataRepo.put).toHaveBeenCalledTimes(1)
+    expect(mockUnimindParametersRepo.getByPair).toHaveBeenCalledTimes(1)
+  })
+})
diff --git a/test/unit/handlers/post-order/post-order.test.ts b/test/unit/handlers/post-order/post-order.test.ts
@@ -75,6 +75,7 @@ const SAMPLE_QUOTE_METADATA = {
   referencePrice: '4221.21',
   priceImpact: 0.01,
   pair: 'ETH-USDC',
+  blockNumber: 123456,
   route: {
     quote: '1234',
     quote_gas_adjusted: '5678',

diff --git a/test/unit/repositories/quote-metadata-repository.test.ts b/test/unit/repositories/quote-metadata-repository.test.ts
@@ -9,6 +9,7 @@ describe('QuoteMetadataRepository', () => {
     quoteId: 'test-quote-id',
     referencePrice: "21212121",
     priceImpact: 0.21,
+    blockNumber: 123456,
     route: {
         quote: "1234",
         quote_gas_adjusted: "5678",