-
Notifications
You must be signed in to change notification settings - Fork 57
[ZH] Make Zero Hour Tools compile with VS2022 c++20 #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZH] Make Zero Hour Tools compile with VS2022 c++20 #509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me overall, some of the things are inconsequential in the end as the tools they are in are likely to end up deprecated in the long run.
15b4e26
to
66fa0a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed a trick when I approved earlier, didn't test the new extras build. The following libraries need gz_config adding to their targets so they correctly use C++20:
CRCDiff
Launcher
mangler
matchbot
timingTest
66fa0a0
to
ca25f40
Compare
Why just these 5? I have now added
This appears to be complete. Is that ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those were just the ones that needed to be C++17 or higher to build correctly based on something in one of compatibility wrappers you wrote, but all targets being bumped is also a perfectly good fix.
Pull number needs to be added to commits. |
ca25f40
to
2f3e632
Compare
2f3e632
to
1751202
Compare
…ring for Zero Hour Tools build (#509)
…ring for Zero Hour Tools build (TheSuperHackers#509)
Merge with Rebase
This change makes Zero Hour Tools build with VS2022 and c++20. It still builds all targets with VS6 and is not expected to change behaviour.
Compile & Linker warnings are not addressed with this change.
(GENZH_BUILD_ZEROHOUR ✔️)
GENZH_BUILD_ZEROHOUR_TOOLS ✔️
(GENZH_BUILD_GENERALS ✔️)
GENZH_BUILD_GENERALS_TOOLS ❌
Zero Hour & Tools build on VS6 ✔️
Zero Hour & Tools build on VS2022 c++20 ✔️
(Generals build on VS6 ✔️)
(Generals build on VS2022 c++20 ✔️)
Commits are split into small chunks for ease of review.