[GEN][ZH] Fix incorrect AsciiString hash implementation for non-stlport

[xezon]

• Merge after [ZH] Make Zero Hour game compile with VS2022 c++20 #426

This error causes the game to crash early with non-stlport builds. The reason is that the hash impl for stlport does not work with the standard/new std::hash.

[DevGeniusCode]

Example error messages:

Sorry, a serious error occurred. (Error parsing INI
 file 'Data\INI\Object\chemicalgeneral.ini' (Line: 'ObjectReskin
 Chem_GLAHoleCommandCenter Chem_GLAHole ")
 )

ASSERTION FAILURE: Invalid FireSound MarauderTankWeapon
in Weapon 'MarauderTankGun'.

[Mauller]

This change corrects the ASCII string parsing and fixes the behaviour.

std::string_view creates a C string out of the ascii string that the std::hash hasher can make use of.

[stevebone]

I have applied this change and the game launches without the ini parsing issues any longer as explained in #491. It crashes during the game but I am unsure whether that is related to this.

[Mauller]

I have applied this change and the game launches without the ini parsing issues any longer as explained in #491. It crashes during the game but I am unsure whether that is related to this.

You also have to apply the Asm fix in #479 as the original Asm causes runtime problems at random.

But this fix corrects the ini failures.

[xezon]

Fix for Generals replicated. Comment simplified. To be merged after VS2022 CI.

[Mauller]

Shouldn't the Generals version also pass a cost reference? Matches the ZH version for completeness then.

[xezon]

Oh right. I did not copy that over properly.

[xezon]

Shouldn't the Generals version also pass a cost reference?

Fixed.