-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VS6] add Dockerfile and docker-compose to build the code #432
base: main
Are you sure you want to change the base?
[VS6] add Dockerfile and docker-compose to build the code #432
Conversation
Dockerfile
Outdated
RUN mv /build/tools/cmd /build/tools/git | ||
|
||
# Install Visual Studio 6 Portable | ||
RUN wget https://github.com/itsmattkc/MSVC600/archive/refs/heads/master.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how I feel about having a dependency on master
branch of a repo outside of our control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we inhouse vs6 in TheSuperHackers as a repo. Otherwise you need to hund it from an outside repo.
itsmattkc is a youtuber i follow an wich i trust to not have tempered with the distribution of vs6. Maby a trusted member can source the vs6 files and provide them in a repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea about the nature of VS6 redistributability. @OmniBlade @Generalcamo thoughts?
Locally I am using the VS6 SP6 package that OmniBlade has put together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea about the nature of VS6 redistributability. @OmniBlade @Generalcamo thoughts?
Locally I am using the VS6 SP6 package that OmniBlade has put together.
Perhaps we can think about making this a mandatory mount that the user provides, that way it is not redistributed inside of the image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @tintinhamans, I am uncomfortable with distributing this.
I have optimized the image. |
Actually, why not expand on this entire idea and implement devcontainers? They are supported in many IDEs: VS, VSCode and more. |
Yeah dev containers are a interesting approach but for this PR its out of scope. |
Signed-off-by: Marcos Gamez <[email protected]>
Added two dockerfiles
Dockerfile & docker-compose.yml
With this two files you can locally build your copy of the source code. The binarys are dropped down on your build directory
./build/docker
No dependency needed to be installed on the development machine only docker