Skip to content

Add async modifier to _deploy on AppGatewayBase #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add async modifier to _deploy on AppGatewayBase #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/base/AppGatewayBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ abstract contract AppGatewayBase is AddressResolverUtil, IAppGateway, FeesPlugin
/// @notice Deploys a contract
/// @param contractId_ The contract ID
/// @param chainSlug_ The chain slug
function _deploy(bytes32 contractId_, uint32 chainSlug_, IsPlug isPlug_) internal {
function _deploy(bytes32 contractId_, uint32 chainSlug_, IsPlug isPlug_) internal async {
_deploy(contractId_, chainSlug_, isPlug_, new bytes(0));
}

Expand All @@ -126,7 +126,7 @@ abstract contract AppGatewayBase is AddressResolverUtil, IAppGateway, FeesPlugin
uint32 chainSlug_,
IsPlug isPlug_,
bytes memory initCallData_
) internal {
) internal async {
address asyncPromise = addressResolver__.deployAsyncPromiseContract(address(this));
isValidPromise[asyncPromise] = true;
IPromise(asyncPromise).then(this.setAddress.selector, abi.encode(chainSlug_, contractId_));
Expand Down
Loading