Skip to content

Add async modifier to _deploy on AppGatewayBase #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add async modifier to _deploy on AppGatewayBase #97

wants to merge 1 commit into from

Conversation

rookmate
Copy link
Contributor

Made deployContracts not be async to ensure I would get the AsyncPromise error but instead got 2 successful transactions that did not deploy my contracts onchain

@rookmate rookmate changed the base branch from staging to redeployments March 24, 2025 13:25
@rookmate rookmate changed the base branch from redeployments to staging March 24, 2025 13:26
@ameeshaagrawal
Copy link
Contributor

added implementation of the same here as discussed: #102

@ameeshaagrawal ameeshaagrawal deleted the add-async branch April 2, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthcp arthcp Awaiting requested review from arthcp

@ameeshaagrawal ameeshaagrawal Awaiting requested review from ameeshaagrawal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rookmate @ameeshaagrawal