Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add convert to short name in GEO #96

Merged
merged 4 commits into from
Jan 24, 2023
Merged

add convert to short name in GEO #96

merged 4 commits into from
Jan 24, 2023

Conversation

davide-f
Copy link
Collaborator

@davide-f davide-f commented Dec 30, 2022

Closes # (if applicable).

Change proposed in this Pull Request

GEO function missed the short_name filtering that is now added.
This partially address #95
Does this need a release_note line?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other

Checklist

  • I have added a note to release notes doc/release_notes.rst.
  • I have used pre-commit run --all to lint/format/check my contribution
  • I have documented the effects of my code changes in the documentation doc/.
  • I have adjusted the docstrings in the code appropriately.

@pz-max
Copy link
Contributor

pz-max commented Jan 6, 2023

@davide-f Made Taiwan run & safes my life 🥳
I think we need something similar for GPD (it has Taiwan data but it was not found for matching)

@davide-f
Copy link
Collaborator Author

davide-f commented Jan 6, 2023

@davide-f Made Taiwan run & safes my life 🥳 I think we need something similar for GPD (it has Taiwan data but it was not found for matching)

Happy to help!
Check if you solve with the latest commit

@davide-f
Copy link
Collaborator Author

@FabianHofmann could you please checkout these two PRs? #97 and #96 (this one)

They are very small but highly needed for pypsa-earth.
A new release after that would be awesome as well if easy to do.

Many thanks

@FabianHofmann FabianHofmann merged commit d9be824 into PyPSA:master Jan 24, 2023
@FabianHofmann
Copy link
Contributor

thanks @davide-f, does not need a release note necessarily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants