-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add run scenarios #543
Add run scenarios #543
Conversation
A technical suggestion: would it be possible to keep all the country names for which GADM_ID codes contain non-standard values, that is letters of It would be very helpful to understand how often fine tuning may be needed when working with administrative data globally. And how much hard-coded could be a solution for non-standard cases :) |
Yeah :) that can be done absolutely, do you have some lines already developed to include that? |
Super :) I have tried here to get use of pandas DataFrame
Agree that we may need an additional safety check to ensure that the workflow will not be stopped due to some I/O errors. But don't have any particular ideas on this (except catching a non-specific exception...) and would be very interested in yours :) |
Absolutely! I'd be more than interested in any kind of validation procedures for renewables. I see here two options:
Regarding the first point I'm afraid we are somewhat constrained with RES data availability for 2013. As for the second approach, in my opinion it's a more "correct" way, and there data availability looks much better here. There are great global-scale meteorological datasets like GHCN or ISD. I think it would be very useful to have an opportunity integrate them in our workflow but it may be not trivial at all :) Probably, as an initial test we could take a couple of dozens locations of meteorological stations (e.g. ones being representative for more or less global picture or just with the highest data quality) and extract wind/solar potential for the buses where these stations belong to? The resulted array could be supplemented with meteorological observations data and used for numerical exercises to obtain a big picture at least in an initial version. What do you think? |
So, I kind of implemented everything on the wish list, at least on a draft way:
They are meant to be simple statistics to check the functionality of the workflow, yet they can be used for validation purposes and easy to expand to include additional features I think this PR is ready for preliminary review and comparison. @pz-max and @ekatef , will you be available tomorrow for the workflow meeting? |
Fantastic! Thank you so much :) Will be happy to discuss details during the today's workflow meeting |
Yes, let's talk today |
A run :)
[Update 3-1-2022] |
Nice map @davide-f . Is this figure created by the workflow? (We should regularly check the situation e.g. on weekly basis in near feature). It really shows that pypsa-earth is not yet stable to run everywhere. |
I'm working on it and we can improve it; it was a nice mapping and testing. I think most of the yellow can be easily fixed. I believe most of the yellow is because of that. Once we have more green for africa, I'll run other countries as well |
A nice and very insightful plot! Would it probably make sense to switch green and dark green to make the color coding more intuitive? (or probably replace gark green with something like gold or yellowgreen?..) Results are a bit surprising: my a priori feeling was that the model works perfectly in 80% cases and tends to make troubles in really complicated cases only :) Is the yellow probably an effect of #531? And does red mean some regional borders uncertainties? Agree that the visualisation works perfectly to highlight the modeling status and it's worth to include it into the regular workflow. Apart of this practical meaning, it's just beautiful :) |
Green/dark green currently is not a problem, though I agree. |
The picture has been created by a notebook. |
Image above updated |
Wow 🤩 An impressive progress! |
Latest changes are updated above. For the purpose of this PR, no more bugfixing is expected, but I'll try run the same code on regions beyond africa. Major needs to improve the current picture are:
To achieve this image, the number of clusters used for the clustering are adjusted by country. |
ef41896
to
f15504c
Compare
Latest updates. I think this image cannot be released as of now: too much non-green in Asia. Priorities to be fixed:
After these fixes, I think the +Asia shape should be ok to be published. |
This PR will be heavily revised in agreement to the new developments on main. |
6e3fd1d
to
a3dac09
Compare
Closes #503
Changes proposed in this Pull Request
This branch aims at creating rules and scripts to iteratively test the workflow on a list of countries.
For each country, the workflow is executed and general statistics are collected.
Intermediate results are also stored.
This can be useful to track the overall status of the workflow for the globe, also collecting statistics that can be useful for validation.
Suggestions are welcome, especially on the statistics to include.
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.