CBO 2025 January baseline update #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2874 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 2618 2618
=========================================
Hits 2618 2618
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@jdebacker This PR is ready for review |
jdebacker
reviewed
Feb 28, 2025
taxcalc/policy.py
Outdated
| @@ -40,9 +40,9 @@ class instance: Policy | |||
| DEFAULTS_FILE_NAME = 'policy_current_law.json' | |||
| DEFAULTS_FILE_PATH = os.path.abspath(os.path.dirname(__file__)) | |||
| JSON_START_YEAR = 2013 # remains the same unless earlier data added | |||
| LAST_KNOWN_YEAR = 2025 # last year for which indexed param vals are known | |||
| LAST_KNOWN_YEAR = 2026 # last year for which indexed param vals are known | |||
There was a problem hiding this comment.
Should the LAST_KNOWN_YEAR stay at 2025? This PR doesn't update with IRS rounding rules.
|
Does |
|
@jdebacker Yes, I agree there should be a change in Already made the corresponding changes and pass the tests |
|
@jdebacker a follow up to see if this PR is good to merge |
|
@bodiyang Looks great! Thanks for this update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update the model with CBO 2025 January baseline update.
New data files including grow factors, puf ratio & weight files are generated from Tax-Data's completed PR work