CHD support (credits to @SleepyMan and @siddhartha77 too)

[rtissera]

This PR tries to resolve remaining issues on #4045 and @siddhartha77 work in order to finally get CHD support in.

[liberodark]

Thank you for this pr.

[rtissera]

(hopefully) fixed the remaining clang issue upstream with rtissera/libchdr@0b6d663
Can someone relaunch the CI or should I do a dummy commit ?

[rtissera]

sorry for all the noise on this PR, I had issues reproducing locally some of your CI scenarios.
Let me know if you can squash and merge or want me to manually redo a "clean" PR from scratch.

[lightningterror]

Would be nice to properly rebase the branch with latest master.

Also name the commits properly with prefixes included.

[rtissera]

@lightningterror let me know if you need another rebase or if it's clean enough to be merged.

[lightningterror]

I'd squash the last commit with the previous 2 ones.

[rtissera]

@lightningterror Sure no problem for the squash, can you do it or should I ?

[lightningterror]

You can do it.

[rtissera]

@lightningterror done, good to go ?

[Florin9doi]

Closes #2584, closes #4045

[refractionpcsx2]

@rtissera sorry can you fix the conflicts? Thanks

[rtissera]

@refractionpcsx2 sure no problem will fix later today

[rtissera]

@refractionpcsx2 rebased on master with fixed conflicts

[refractionpcsx2]

Awesome, thanks, now we can merge :)

[matoro]

Hello, is there going to be an option to use the system version of this new library instead of the submodule one, like yaml-cpp?

[tony971]

CHD files are not listed as options under "Boot ISO"

[refractionpcsx2]

CHD files are not listed as options under "Boot ISO"

Boot ISO is the same thing. We can rename it "Boot Image" if it really bothers you.

[tony971]

CHD files are not listed as options under "Boot ISO"

Boot ISO is the same thing. We can rename it "Boot Image" if it really bothers you.

I didn't communicate effectively enough. If you go to "Boot ISO", it won't find chd files. It's not one of the available options.

[refractionpcsx2]

If you're using a buildbot build, they are out of date, for some reason it isn't building, so CHD isn't available in those builds yet. we are working on it.

if you need a build you can join our discord, there is one posted in the #dev-builds channel

[tony971]

The latest buildbot is bc477e1. That looks to be the head.

[refractionpcsx2]

The latest buildbot is bc477e1. That looks to be the head.

no, the last buildbot build is dated 2021-03-15 13:16:20, which is from before the CHD stuff.

You can't go off what's on the PCSX2 page, that lists every commit regardless, you need to go actually on to the buildbot to see the correct build.

[RedDevilus]

Orphis buildbots (1.7-1149):

Actual latest from github (1.7-1154):

[tony971]

Yep, PEBCAK. Sorry for wasting your time.

[refractionpcsx2]

No problems, you're not the first who's been confused.