-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CHD file support #2
Conversation
It would be prudent to check out this PR and the resulting issues with large file support across platforms. |
@siddhartha77 Looks like libchdr maintainer wants you to make some edits to merge the changes upstream to libretro |
@siddhartha77 any updates? |
libchdr rtissera/libchdr#42 by @SleepyMan was finally merged. |
Any chance on this getting merged soon? There are a lot of files greater than 2GB in CHD format left to support. |
I don't get it. |
It does work, but it appears this request will fix the > 2GB CHD? I'm getting the following errors on boot for any CHD compressed PS2 game greater than 2GB. Every CHD < 2GB works fine though. isoFile error: Block index is past the end of file! (1502786 >= 1121296). and either the emulator crashes or the game never starts |
i just tried a 2.5gb CHD, and it booted just fine here. |
Sorry, I've been offline for so long. Life. Can I confirm your operating system and which version of PCSX2 you are compiling? |
I have just tried the latest nightly Windows build and compiled the latest Linux version (the same @ 2901830) on Ubuntu 20.04. Both were able to boot into a God of War CHD that is over 6.8 GB. Thanks to everyone, especially @rtissera for all their hard work. |
Okay, here are all my changes. You should be able to merge it easily and update PCSX2#4045 to finally close PCSX2#2584. It will compile on Ubuntu 20.04 and MSVC 2019 Community. Most of the changes were with the directory structure, CMAKE files, and the MSVC files. I also added large file support for >2GB CHDs.
One thing we should eventually do is update it to use xz instead of lzma, but that will take a ton of work.
Thanks for all your hard work too!