Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHD file support #2

Closed
wants to merge 1 commit into from
Closed

Add CHD file support #2

wants to merge 1 commit into from

Conversation

siddhartha77
Copy link

@siddhartha77 siddhartha77 commented Jan 11, 2021

Okay, here are all my changes. You should be able to merge it easily and update PCSX2#4045 to finally close PCSX2#2584. It will compile on Ubuntu 20.04 and MSVC 2019 Community. Most of the changes were with the directory structure, CMAKE files, and the MSVC files. I also added large file support for >2GB CHDs.

One thing we should eventually do is update it to use xz instead of lzma, but that will take a ton of work.

Thanks for all your hard work too!

@siddhartha77
Copy link
Author

siddhartha77 commented Jan 23, 2021

It would be prudent to check out this PR and the resulting issues with large file support across platforms.

@0x90shell
Copy link

@siddhartha77 Looks like libchdr maintainer wants you to make some edits to merge the changes upstream to libretro

@BakedCrossiant
Copy link

@siddhartha77 any updates?

@rtissera
Copy link

libchdr rtissera/libchdr#42 by @SleepyMan was finally merged.

@tempt187
Copy link

Any chance on this getting merged soon? There are a lot of files greater than 2GB in CHD format left to support.

@rtissera
Copy link

I don't get it.
CHD support was merged in PCSX2 upstream check PCSX2#4314

@tempt187
Copy link

I don't get it.
CHD support was merged in PCSX2 upstream check PCSX2#4314

It does work, but it appears this request will fix the > 2GB CHD? I'm getting the following errors on boot for any CHD compressed PS2 game greater than 2GB. Every CHD < 2GB works fine though.

isoFile error: Block index is past the end of file! (1502786 >= 1121296).
isoFile error: Block index is past the end of file! (1502787 >= 1121296)

and either the emulator crashes or the game never starts

@Dio141
Copy link

Dio141 commented Apr 18, 2021

I don't get it.
CHD support was merged in PCSX2 upstream check PCSX2#4314

It does work, but it appears this request will fix the > 2GB CHD? I'm getting the following errors on boot for any CHD compressed PS2 game greater than 2GB. Every CHD < 2GB works fine though.

isoFile error: Block index is past the end of file! (1502786 >= 1121296).
isoFile error: Block index is past the end of file! (1502787 >= 1121296)

and either the emulator crashes or the game never starts

i just tried a 2.5gb CHD, and it booted just fine here.

@siddhartha77
Copy link
Author

I don't get it.
CHD support was merged in PCSX2 upstream check PCSX2#4314

It does work, but it appears this request will fix the > 2GB CHD? I'm getting the following errors on boot for any CHD compressed PS2 game greater than 2GB. Every CHD < 2GB works fine though.

isoFile error: Block index is past the end of file! (1502786 >= 1121296).
isoFile error: Block index is past the end of file! (1502787 >= 1121296)

and either the emulator crashes or the game never starts

Sorry, I've been offline for so long. Life.

Can I confirm your operating system and which version of PCSX2 you are compiling?

@siddhartha77
Copy link
Author

siddhartha77 commented Apr 25, 2021

I have just tried the latest nightly Windows build and compiled the latest Linux version (the same @ 2901830) on Ubuntu 20.04. Both were able to boot into a God of War CHD that is over 6.8 GB.

Thanks to everyone, especially @rtissera for all their hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]Add CHD format support for compressed disc
6 participants