[17.0][MIG] sale_triple_discount: Migration to 17.0 #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boxnia
changed the title
test-requirements.txt
Outdated
| @@ -0,0 +1 @@ | |||
| odoo-addon-account_invoice_triple_discount @ git+https://github.com/OCA/account-invoicing.git@refs/pull/1626/head#subdirectory=account_invoice_triple_discount | |||
There was a problem hiding this comment.
Suggested change
| odoo-addon-account_invoice_triple_discount @ git+https://github.com/OCA/account-invoicing.git@refs/pull/1626/head#subdirectory=account_invoice_triple_discount | |
| odoo-addon-account_invoice_triple_discount @ git+https://github.com/OCA/account-invoicing.git@refs/pull/1626/head#subdirectory=setup/account_invoice_triple_discount |
There was a problem hiding this comment.
Ugh changed for v17. Ok
Boxnia
force-pushed
the
17.0-mig-sale_triple_discount
branch
from
609f887
to
578aae9
Compare
|
@rousseldenis I have changedthe test-requirement but the bug is the same. Thanks |
OCA Transbot updated translations from Transifex [UPD] Update sale_triple_discount.pot
Currently translated at 100,0% (5 of 5 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_triple_discount/nl_NL/
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_triple_discount/nl_NL/
…onsistency [FIX] sale_triple_discount: Invalidating the cache of specific records before recomputing price and discount [UPD] Update sale_triple_discount.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-10.0/sale-workflow-10.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_triple_discount/
…3 in the computation
[UPD] Update sale_triple_discount.pot
[UPD] Update sale_triple_discount.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_triple_discount/
[UPD] Update sale_triple_discount.pot [UPD] README.rst
Currently translated at 100.0% (11 of 11 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_triple_discount/it/ [UPD] README.rst [UPD] README.rst
Currently translated at 0.0% (0 of 11 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_triple_discount/fr/
[UPD] Update sale_triple_discount.pot [UPD] README.rst
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_triple_discount/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/
Currently translated at 100.0% (12 of 12 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/es_MX/
Currently translated at 100.0% (12 of 12 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/it/
Currently translated at 100.0% (12 of 12 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/es/
Currently translated at 100.0% (12 of 12 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/it/
Currently translated at 100.0% (12 of 12 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_triple_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_triple_discount/de/
Boxnia
force-pushed
the
17.0-mig-sale_triple_discount
branch
from
578aae9
to
94c2697
Compare
traitrantrobz
suggested changes
Aug 8, 2024
There was a problem hiding this comment.
@Boxnia I don't know the reason why i cannot edit the discount1-2-3 field on sale the order line. It gets reset after I edit it. Please deouble-check it. Thank you!
|
@Boxnia Thanks for the mig, I guess we'll want to bring #3157 in v17.0 from the get go, although it's not merged in 16.0 yet. We discussed the same for account_invoice_triple_discount here: OCA/account-invoicing#1626 (comment) |
dalonsod
suggested changes
Nov 12, 2024
| this method is called multiple times. | ||
| Updating the cache provides consistency through re-computations.""" | ||
| prev_values = dict() | ||
| self.invalidate_model(self._discount_fields(), self.ids) |
There was a problem hiding this comment.
@Boxnia @traitrantrobz regarding to issue commented at #3157 (review) I've simply removed this line and it worked for me, could you check?
Suggested change
| self.invalidate_model(self._discount_fields(), self.ids) |
Comment on lines
+121
to
+124
| self.invalidate_model( | ||
| self._discount_fields(), | ||
| [line.id for line in list(prev_values.keys())], | ||
| ) |
There was a problem hiding this comment.
I don't know if it is now needed. Anyway, invalidate_model signature for v17 seems to be different than used (and invalidate_recordset should be used instead), could you check?
3 tasks
|
Superseded by #3406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration to 17.0
Depends on:
[17.0][MIG] account_invoice_triple_discount: Migration to 17.0 account-invoicing#1626