[17.0][MIG] sale_order_general_discount_triple: Migration to 17.0 #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arantxa-s73
force-pushed
the
17.0-mig-sale_order_general_discount_triple
branch
2 times, most recently
from
1135d57
to
52e968a
Compare
|
/ocabot migration sale_order_general_discount_triple |
arantxa-s73
force-pushed
the
17.0-mig-sale_order_general_discount_triple
branch
from
52e968a
to
dc30533
Compare
Currently translated at 100.0% (11 of 11 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_general_discount_triple Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_general_discount_triple/it/
Use `update` instead of `write` to avoid caching issue
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_general_discount_triple Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_general_discount_triple/
Changing the field `discount` to a not computed one is breaking standard flows, provoking all sorts of errors when this module is installed, so we disable for now the module while not finding other option that will be reported to original migrators.
Discount behaviuour in v16.0 is to be computed but in this module it was changed. Here we are using compute_discount method to archive the functionallity and also converting the remaining two discounts to computed fields.
Pricelist discount was overide by general discount functionality. With this change, its up to the user to choose in which discount wants to apply general and pricelist disounts.
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_general_discount_triple Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_general_discount_triple/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_general_discount_triple Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_general_discount_triple/
Currently translated at 100.0% (10 of 10 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_general_discount_triple Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_general_discount_triple/es/
…or res.config.settings - Field mark as required cause issues with other modules
Currently translated at 100.0% (10 of 10 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_general_discount_triple Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_general_discount_triple/it/
sbiosca-s73
force-pushed
the
17.0-mig-sale_order_general_discount_triple
branch
from
dc30533
to
bcd82e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: