Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] account_banking_mandate_contact: Show contact mandate account bank in invoice report #1282

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][IMP] account_banking_mandate_contact: Show contact mandate account bank in invoice report #1282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions account_banking_mandate_contact/models/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
from . import account_move
from . import account_move_line
from . import res_partner
19 changes: 19 additions & 0 deletions account_banking_mandate_contact/models/account_move.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Copyright 2024 Tecnativa - Carlos Dauden
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).

from odoo import models


class AccountMove(models.Model):
_inherit = "account.move"

def partner_banks_to_show(self):
self.ensure_one()
p_shipping_bank_id = self.partner_shipping_id.valid_mandate_id.partner_bank_id
if (
p_shipping_bank_id
and not self.partner_bank_id
and self.payment_mode_id.payment_method_id.code == "sepa_direct_debit"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that for decoupling this module from SEPA DD, we should:

Suggested change
and self.payment_mode_id.payment_method_id.code == "sepa_direct_debit"
and not self.payment_mode_id.show_bank_account_from_journal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, what will happen when a contact has a specific mandate and an invoice is printed where, exceptionally, payment by transfer has been established?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the problem with the existing code?
Establishing a bank mandate at the contact level cannot be too decoupled from SEPA DD.

Copy link
Member

@pedrobaeza pedrobaeza Jun 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without having installed account_banking_sepa_direct_debit, this patch won't work, so that's the coupling.

I see that the same coupling is right now on account_payment_partner:

bank-payment/account_payment_partner/models/account_move.py

Line 154 in 87c513b

self.payment_mode_id.payment_method_id.code == "sepa_direct_debit"

and this was highlighted already in this comment: #1219 (comment)

I think it's the duty of the user to configure correctly the payment mode to show or not customer bank accounts. It's not like how they are forced to show it. Users have the control over this.

What do you think about changing this in both parts with a migration script setting to not show the bank account if it's set that way but not sepa_direct_debit? Do you want me to do it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, do what you think, I just want the client to see what he expects.

):
return p_shipping_bank_id
return super().partner_banks_to_show()
Loading