[15.0][IMP] account_banking_mandate_contact: Show contact mandate account bank in invoice report #1282
Conversation
…ank in invoice report TT49436
| if ( | ||
| p_shipping_bank_id | ||
| and not self.partner_bank_id | ||
| and self.payment_mode_id.payment_method_id.code == "sepa_direct_debit" |
There was a problem hiding this comment.
I think that for decoupling this module from SEPA DD, we should:
| and self.payment_mode_id.payment_method_id.code == "sepa_direct_debit" | |
| and not self.payment_mode_id.show_bank_account_from_journal |
There was a problem hiding this comment.
With this change, what will happen when a contact has a specific mandate and an invoice is printed where, exceptionally, payment by transfer has been established?
There was a problem hiding this comment.
What is the problem with the existing code?
Establishing a bank mandate at the contact level cannot be too decoupled from SEPA DD.
There was a problem hiding this comment.
Without having installed account_banking_sepa_direct_debit, this patch won't work, so that's the coupling.
I see that the same coupling is right now on account_payment_partner:
and this was highlighted already in this comment: #1219 (comment)
I think it's the duty of the user to configure correctly the payment mode to show or not customer bank accounts. It's not like how they are forced to show it. Users have the control over this.
What do you think about changing this in both parts with a migration script setting to not show the bank account if it's set that way but not sepa_direct_debit? Do you want me to do it?
There was a problem hiding this comment.
Ok, do what you think, I just want the client to see what he expects.
|
This PR has the |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
pedrobaeza
removed
the
stale
@Tecnativa TT49436