Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lemurs: 0.3.2-unstable-2024-07-24 -> 0.4.0; use versionCheckHook #384243

Merged
merged 2 commits into from
Feb 23, 2025

Conversation

nullcubee
Copy link
Contributor

@nullcubee nullcubee commented Feb 22, 2025

I'm having some deja vu...

Updated lemurs to version 0.4.0, which includes many fixes for nixos.

Replaced testers.testVersion with versionCheckHook:
#384243 (comment)

Changelog:
https://github.com/coastalwhite/lemurs/releases/tag/v0.4.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 22, 2025
@nix-owners nix-owners bot requested a review from JeremiahSecrist February 22, 2025 13:37
@nullcubee
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 384243


x86_64-linux

✅ 1 package built:
  • lemurs

@nullcubee nullcubee changed the title lemurs: 0.3.2-unstable-2024-07-24 -> 0.4.0 lemurs: 0.3.2-unstable-2024-07-24 -> 0.4.0; use versionCheckHook Feb 23, 2025
@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 384243

@nullcubee
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 384243


x86_64-linux

✅ 1 package built:
  • lemurs

@Stunkymonkey Stunkymonkey merged commit 70e259a into NixOS:master Feb 23, 2025
48 of 51 checks passed
@nullcubee nullcubee deleted the update/lemurs-0-4-0 branch February 23, 2025 14:26
@nullcubee nullcubee mentioned this pull request Feb 28, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants