Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/lemurs: init #329496

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

Stunkymonkey
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 23, 2024
@Stunkymonkey Stunkymonkey force-pushed the nixos-lemurs-init branch 2 times, most recently from f3bcfc1 to 9c8ec18 Compare July 23, 2024 20:50
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jul 23, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 23, 2024
@coastalwhite
Copy link

Creator and maintainer of lemurs here. If you need anything else to make this possible, let me know.

@Stunkymonkey
Copy link
Contributor Author

@coastalwhite i added a basic test.

should we offer options to configure /etc/lemurs/wms//etc/lemurs/wayland?

@coastalwhite
Copy link

coastalwhite commented Jul 26, 2024

No if possible. We should use the xsessions and wayland sessions standard directories. That way if people add window managers or desktop environments, they should show up automatically.

There are both CLI and config options to set the paths to those.

@coastalwhite
Copy link

If you want an example on how that is done, you can take a look here.

https://github.com/NullCub3/lemurs/blob/nixosmodule-dev/nix/lemurs-module.nix

They use the existing sessionData to set both the xsessions and waylandSessions in the config.

@h7x4 h7x4 added the 8.has: tests This PR has tests label Jul 27, 2024
@phanirithvij
Copy link
Member

phanirithvij commented Aug 6, 2024

There's also master...Vonfry:nixpkgs:init-lemurs-module by @Vonfry who wrote the ly module #297434. No pr was made for it, it seems.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/lemurs-dm-doesnt-work/45300/3

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@Stunkymonkey Stunkymonkey removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 24, 2024
@supermarin
Copy link
Contributor

+1 what's needed to move this forward?
I saw on Discourse that the lemurs package itself is outdated in nixpkgs, other than that any other blockers?

@Stunkymonkey
Copy link
Contributor Author

@supermarin so the "start" part is done. I used to test it on my raspberry-pi and it showed up, but sadly login was never perfect. tty works fine.

So everything including and after login, is missing. Feel free to work on it.

For testing I used:

  services.lemurs.enable = true;
  environment.etc."lemurs/wayland/sway" = {
    enable = true;
    mode = "0755";
    text = ''
      #! /bin/sh
      exec ${lib.getExe pkgs.sway}
    '';
  };

@supermarin
Copy link
Contributor

@Stunkymonkey thanks! didn't know it's in a non working state, don't have bandwidth to troubleshoot it ATM. Have you tried with the newer lemurs (0.3.2-unstable) that was just merged?

@nullcubee
Copy link
Contributor

FYI, #384243 was also merged, which updates lemurs to 0.4.0.

I've been doing some testing on my own module which uses the latest version and I've been running into the same sort of issues, TTY login works fine but I can't seem to get a graphical session working correctly. Not sure what's up, mine has something to do with dbus saying it can't initialize an X11 session, even though I'm trying to start a wayland one. Haven't tested for X11 yet.

I think I might give some testing on this module a shot as well, see if I can figure out anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants