-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/lemurs: init #329496
base: master
Are you sure you want to change the base?
nixos/lemurs: init #329496
Conversation
f3bcfc1
to
9c8ec18
Compare
Creator and maintainer of lemurs here. If you need anything else to make this possible, let me know. |
97654d5
to
95eaaa8
Compare
@coastalwhite i added a basic test. should we offer options to configure |
No if possible. We should use the xsessions and wayland sessions standard directories. That way if people add window managers or desktop environments, they should show up automatically. There are both CLI and config options to set the paths to those. |
If you want an example on how that is done, you can take a look here. https://github.com/NullCub3/lemurs/blob/nixosmodule-dev/nix/lemurs-module.nix They use the existing |
There's also master...Vonfry:nixpkgs:init-lemurs-module by @Vonfry who wrote the ly module #297434. No pr was made for it, it seems. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
95eaaa8
to
c0a4b0c
Compare
c0a4b0c
to
489899b
Compare
+1 what's needed to move this forward? |
@supermarin so the "start" part is done. I used to test it on my raspberry-pi and it showed up, but sadly login was never perfect. tty works fine. So everything including and after login, is missing. Feel free to work on it. For testing I used:
|
@Stunkymonkey thanks! didn't know it's in a non working state, don't have bandwidth to troubleshoot it ATM. Have you tried with the newer lemurs (0.3.2-unstable) that was just merged? |
FYI, #384243 was also merged, which updates lemurs to 0.4.0. I've been doing some testing on my own module which uses the latest version and I've been running into the same sort of issues, TTY login works fine but I can't seem to get a graphical session working correctly. Not sure what's up, mine has something to do with dbus saying it can't initialize an X11 session, even though I'm trying to start a wayland one. Haven't tested for X11 yet. I think I might give some testing on this module a shot as well, see if I can figure out anything. |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.