Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lemurs: 0.3.2 -> 0.3.2-unstable-2024-07-24; add maintainer; cleanup with lib; #384051

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

nullcubee
Copy link
Contributor

@nullcubee nullcubee commented Feb 21, 2025

Updated Lemurs to it's latest git revision, as the current version includes hardcoded paths to binaries, making it very difficult to get working correctly under nix. These changes include configuration options to use user-defined paths, e.g. /run/current-system/sw/bin/xorg for a hypothetical NixOS configuration.

Full Changes:
coastalwhite/lemurs@v0.3.2...main

More info on Lemurs NixOS support:
coastalwhite/lemurs#206
https://discourse.nixos.org/t/lemurs-dm-doesnt-work/45300/4?u=nullcube
#329496

Added bash and systemdMinimal to the buildInputs for Lemurs, bash is basically a required dependency, and systemdMinimal is for the power controls by default. These changes aren't strictly necessary so if I'm misremembering how buildInputs works, or if anybody objects, I can remove them.

Added myself as a maintainer for Lemurs.

Removed meta = with lib;, tracking #208242

Tagging
@coastalwhite, @Stunkymonkey, @JeremiahSecrist

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nullcubee nullcubee changed the title Lemurs: 0.3.2 -> 0.3.2-unstable-2024-07-24; add maintainer; cleanup with lib; lemurs: 0.3.2 -> 0.3.2-unstable-2024-07-24; add maintainer; cleanup with lib; Feb 21, 2025
@nullcubee
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 384051


x86_64-linux

✅ 1 package built:
  • lemurs

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Feb 21, 2025
@nix-owners nix-owners bot requested a review from JeremiahSecrist February 21, 2025 21:50
@nullcubee
Copy link
Contributor Author

@Stunkymonkey if you would like me to add you as a maintainer for the lemurs package as well, let me know

@Stunkymonkey
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 384051


x86_64-linux

✅ 1 package built:
  • lemurs

Copy link
Contributor

@JeremiahSecrist JeremiahSecrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! builds on my end, I never got around to building a nixos module for this as it ended up not being something I used.

@Stunkymonkey Stunkymonkey merged commit 6233f69 into NixOS:master Feb 21, 2025
64 of 67 checks passed
@nullcubee nullcubee deleted the lemurs-update-unstable branch February 21, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants