Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11] workflows/eval: fail hard without target run #379302

Merged
merged 2 commits into from
Feb 4, 2025
Merged

[Backport release-24.11] workflows/eval: fail hard without target run #379302

merged 2 commits into from
Feb 4, 2025

Conversation

nixpkgs-ci[bot]
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Feb 4, 2025

Bot-based backport to release-24.11, triggered by a label in #378909.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@wolfgangwalther @github-actions
workflows/eval: fail hard without target run
0efb3c5 
Without a target run, we won't get any rebuild labels, rebuild counts or
maintainer pings. This might have been correct before #373935, but by
now we run eval on all commits on the target branch, so we should treat
it as a failure if we can't find the run.

(cherry picked from commit 86a38d4)
@wolfgangwalther @github-actions
workflows/eval: rename BASE_SHA to TARGET_SHA
5ec6b11 
To be in line with the terminology introduced in the README.md in the
same folder.

(cherry picked from commit 93df51f)
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Feb 4, 2025
Merged
1 task
@github-actions github-actions bot added 6.topic: policy discussion 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Feb 4, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 4, 2025
@infinisil infinisil merged commit b995498 into release-24.11 Feb 4, 2025
25 of 28 checks passed
@wolfgangwalther wolfgangwalther deleted the backport-378909-to-release-24.11 branch February 4, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@risicle risicle Awaiting requested review from risicle

@LeSuisse LeSuisse Awaiting requested review from LeSuisse

@zowoq zowoq Awaiting requested review from zowoq

@mweinelt mweinelt Awaiting requested review from mweinelt

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infinisil @wolfgangwalther