Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI hotfix: NGC access #683

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CI hotfix: NGC access #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sub-packages/bionemo-core/tests/bionemo/core/data/test_load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ def test_load_raises_error_on_invalid_tag(tmp_path):
def test_load_cli():
# It looks like there's some issues with our NGC resources, but this is blocking CI. TODO: Revert to ngc when these
# resources are available.
# FIXME (dorotat): set source=ngc once the access issue with NGC is resolved (https://github.com/NVIDIA/bionemo-framework/issues/682)
result = subprocess.run(
["download_bionemo_data", "--source", "ngc", "single_cell/testdata-20240506"],
["download_bionemo_data", "--source", "pbss", "single_cell/testdata-20240506"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just xfail this test for now? This will never pass in our pre-merge CI that runs off-prem

stdout=subprocess.PIPE, # Capture stdout
stderr=subprocess.PIPE, # Capture stderr (optional)
text=True, # Return output as string rather than bytes
Expand Down
3 changes: 2 additions & 1 deletion sub-packages/bionemo-core/tests/bionemo/core/data/test_load_notebook.ipynb
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of this test was that the ngcsdk library uses an asyncio loop that previously failed in a notebook setting. We've now wrapped that such that it works in a notebook, so this is a regression test that makes sure that stays supported.

Can we change the data target? Ideally there would be some public <1kb test file we could download just to ensure the connection is alive.

Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@
}
],
"source": [
"# FIXME (dorotat): set source=ngc once the access issue with NGC is resolved (https://github.com/NVIDIA/bionemo-framework/issues/682)\n",
"with tempfile.TemporaryDirectory() as cache_dir:\n",
" load(\"scdl/sample\", source=\"ngc\", cache_dir=Path(cache_dir))"
" load(\"scdl/sample\", source=\"pbss\", cache_dir=Path(cache_dir))"
]
}
],
Expand Down
Loading