Patchfix ARM rsync vulnerability in container, bump release version. #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trvachov
requested review from
dorotat-nv,
jstjohn,
malcolmgreaves,
pstjohn,
sichu2023,
skothenhill-nv,
jomitchellnv,
jwilber and
cspades
as code owners
|
/build-ci |
pstjohn
approved these changes
Jan 28, 2025
| @@ -345,6 +345,19 @@ COPY ./docs ./docs | |||
| COPY --from=rust-env /usr/local/cargo /usr/local/cargo | |||
| COPY --from=rust-env /usr/local/rustup /usr/local/rustup | |||
|
|
|||
| # Remove security vuln with rsync on ARM systems: | |||
There was a problem hiding this comment.
We just removed rsync in the amd64 container, do we really need it?
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 118 118
Lines 7059 7059
=======================================
Hits 6124 6124
Misses 935 935 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an ARM security vulnerability in rsync by downloading newest rsync, and also bumps release version (forgot to do this in relase notes)
Type of changes
CI Pipeline Configuration
Configure CI behavior by applying the relevant labels:
Note
By default, the notebooks validation tests are skipped unless explicitly enabled.
Usage
Pre-submit Checklist