Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated puppeteer to the latest version #146

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Updated puppeteer to the latest version #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d8e9aa
Updated puppeteer to the latest version
viccon Mar 11, 2025
9720b74
Launch puppeteer with no sandbox
viccon Mar 11, 2025
7323f87
Update actions/upload-artifact to v4
viccon Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- run: yarn build
- run: yarn package
- name: Archive packages
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: packages
path: artifacts
4 changes: 3 additions & 1 deletion examples/benchmarking/compare.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ const compare = async (optionA: string, optionB: string, targetRelativePerforman

// Puppeteer doesn't really have a `launch` named export.
// eslint-disable-next-line import/no-named-as-default-member
const browser = await puppeteer.launch()
const browser = await puppeteer.launch({
args: ['--no-sandbox'],
})

interface TraceEvent {
name: string
Expand Down
2 changes: 1 addition & 1 deletion examples/benchmarking/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"fs-extra": "^10.0.0",
"html-webpack-plugin": "^5.3.2",
"http-server": "^13.0.2",
"puppeteer": "^10.4.0",
"puppeteer": "^24.4.0",
"ts-loader": "^9.2.5",
"ts-node": "^10.3.1",
"typescript": "^4.8.2",
Expand Down
Loading