Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong naming of codecov config file #649

Closed
wants to merge 4 commits into from

Conversation

Splines
Copy link
Member

@Splines Splines commented Jun 1, 2024

The spec/ folder should be ignored by Codecov here. Apparently this is not the case due to a wrong naming of the config file (it is referenced in the last line of .github/workflows/tests.yml).

Linked issue: codecov/codecov-action#1465 -> it's being worked on, yeah ❤

For reviewers

  • spec folder does not count to code coverage anymore (for the current PR view in Codecov, Link TODO)

@Splines Splines added CI/CD Continuous Integration / Continuous Delivery (aka pipeline stuff) tests Unit tests, integration tests etc. labels Jun 1, 2024
@Splines Splines self-assigned this Jun 1, 2024
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.63%. Comparing base (0c841de) to head (360ef59).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #649   +/-   ##
=======================================
  Coverage   66.63%   66.63%           
=======================================
  Files         309      309           
  Lines        9384     9384           
=======================================
  Hits         6253     6253           
  Misses       3131     3131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Splines Splines marked this pull request as draft June 1, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous Integration / Continuous Delivery (aka pipeline stuff) tests Unit tests, integration tests etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant