-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Codecov patch/project checks in CI/CD #664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splines
added
CI/CD
Continuous Integration / Continuous Delivery (aka pipeline stuff)
tests
Unit tests, integration tests etc.
labels
Jul 8, 2024
Splines
changed the title
Tests/codecov status checks
Disable Codecov patch/project checks in CI/CD
Jul 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #664 +/- ##
===========================================
- Coverage 66.64% 53.09% -13.55%
===========================================
Files 308 153 -155
Lines 9386 6614 -2772
===========================================
- Hits 6255 3512 -2743
+ Misses 3131 3102 -29 ☔ View full report in Codecov by Sentry. |
fosterfarrell9
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.codecov.yml
file back to the root of the repository. Unfortunately, thecodecov_yml_path
is buggy, see this issue: "Ignore paths" not working with custom Codecov config file location codecov/codecov-action#1465. Once that is resolved we may switch back to the new.config
folder location. Having placed the config file into the root, Codecov now correctly reads the file and also ignores thespec
folder. Note that the Codecov report is only generated once the test job was executed in GitHub Actions.