Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting Windows Build Minimum Requirements #937

Merged
merged 7 commits into from
Mar 12, 2025

Conversation

kab163
Copy link
Collaborator

@kab163 kab163 commented Mar 10, 2025

No description provided.

@kab163
Copy link
Collaborator Author

kab163 commented Mar 10, 2025

With the cmake fatal error message set, when I turn off the filesystem:

-- Setting C standard to 99
-- Checking for std::filesystem
-- std::filesystem NOT found, using POSIX
CMake Error at CMakeLists.txt:139 (message):
      Windows builds require the FileSystem to be enabled     and the C/C++ standard to be set to 17 or higher.     Please re-configure with UMPIRE_ENABLE_FILESYSTEM=ON,     with BLT_CXX_STD=c++17 and CMAKE_CXX_STANDARD=17. 


-- Configuring incomplete, errors occurred!
Error: Process completed with exit code 1.

So the cmake stuff seems to work.

@kab163 kab163 requested a review from davidbeckingsale March 10, 2025 23:57
@davidbeckingsale davidbeckingsale dismissed their stale review March 11, 2025 15:44

Accidental approval

Co-authored-by: David Beckingsale <[email protected]>
@kab163 kab163 merged commit 8ea8f47 into develop Mar 12, 2025
18 checks passed
@kab163 kab163 deleted the kab163/windows-build-fix branch March 12, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants