Skip to content

Commit 8ea8f47

Browse files
Documenting Windows Build Minimum Requirements (#937)
* testing that cxx standard less than 17 and filesystem off breaks build * Turning filesystem on, but keeping cxx standard below 17 * Using CXX standard 17 and turning filesystem on, but also setting blt standard to 17 * adding a cmake check and breaking the build to see if the check works * turning back on filesystem * making sure the cmake error checks for c++17 or greater * Update CMakeLists.txt Co-authored-by: David Beckingsale <[email protected]> --------- Co-authored-by: David Beckingsale <[email protected]>
1 parent ffeffc5 commit 8ea8f47

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

.github/workflows/build.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ jobs:
6060
UMPIRE_ENABLE_TOOLS=Off
6161
UMPIRE_ENABLE_DEVELOPER_BENCHMARKS=On
6262
UMPIRE_ENABLE_BENCHMARKS=Off
63-
BLT_CXX_STD=""
63+
BLT_CXX_STD="c++17"
6464
CMAKE_CXX_STANDARD=17
6565
CMAKE_BUILD_TYPE=Release
6666
${{ matrix.shared.args }}
6767
run-build: true
68-
build-args: '--parallel 16'
68+
build-args: '--parallel 16'

CMakeLists.txt

+10
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,16 @@ include(cmake/SetupCMakeBasics.cmake)
134134
include(cmake/SetupCompilerFlags.cmake)
135135
include(cmake/SetupUmpireThirdParty.cmake)
136136

137+
if (WIN32)
138+
if ((NOT UMPIRE_ENABLE_FILESYSTEM) OR (CMAKE_CXX_STANDARD LESS 17))
139+
message(FATAL_ERROR "\
140+
Windows builds require the FileSystem to be enabled \
141+
and the C/C++ standard to be set to 17 or higher. \
142+
Please re-configure with UMPIRE_ENABLE_FILESYSTEM=ON, \
143+
with BLT_CXX_STD=c++17 or greater.")
144+
endif()
145+
endif()
146+
137147
add_subdirectory(src)
138148

139149
configure_package_config_file(

0 commit comments

Comments
 (0)