Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12536 - adding '$' to the unwanted_citation_key_characters #12796

Merged
merged 7 commits into from
Mar 22, 2025

Conversation

jnchin314
Copy link
Contributor

@jnchin314 jnchin314 commented Mar 21, 2025

…ult.

Closes #12536

I added the $ to the default unwanted_citation_key_characters

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.
Screenshot 2025-03-21 at 3 23 51 PM Screenshot 2025-03-21 at 3 24 24 PM Screenshot 2025-03-21 at 3 25 08 PM Screenshot 2025-03-21 at 3 25 48 PM

@jnchin314
Copy link
Contributor Author

PR for the docs

JabRef/user-documentation#558

@jnchin314 jnchin314 changed the title #12536 - adding '$' to the unwanted_citation_key_characters as a defa… #12536 - adding '$' to the unwanted_citation_key_characters Mar 21, 2025
subhramit
subhramit previously approved these changes Mar 22, 2025
@calixtus
Copy link
Member

User facing change requires a change log entry

@subhramit
Copy link
Member

@jnchin314 why is the mandatory check ticked if you didn't add a changelog entry? Did you read before ticking the rest?

@jnchin314
Copy link
Contributor Author

jnchin314 commented Mar 22, 2025

Ahh my bad. I didn't commit and push it!

Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You put your entry in the already published part 6.0-alpha. It belongs in the unreleased part.

@calixtus
Copy link
Member

Fixed it

@calixtus calixtus enabled auto-merge March 22, 2025 14:29
@calixtus calixtus requested a review from subhramit March 22, 2025 14:29
@calixtus calixtus added this pull request to the merge queue Mar 22, 2025
Copy link

trag-bot bot commented Mar 22, 2025

👋 Hey! As a free user, you're receiving reviews for every 5th PR. Upgrade to get reviews on every pull request and boost your code quality! Learn more here 🚀

@jnchin314
Copy link
Contributor Author

Thanks for fixing I would've moved it to the correct spot. I'll remember this for next time!

auto-merge was automatically disabled March 22, 2025 14:40

Pull Request is not mergeable

Merged via the queue into JabRef:main with commit c44ddbe Mar 22, 2025
7 checks passed
@koppor
Copy link
Member

koppor commented Mar 23, 2025

Prefernce migration is missing!

GuilhermeRibeiroPereira pushed a commit to GuilhermeRibeiroPereira/jabref that referenced this pull request Apr 1, 2025
…bRef#12796)

* JabRef#12536 - adding '$' to the unwanted_citation_key_characters as a default.

* JabRef#12536 - changelog!

* Update CHANGELOG.md

---------

Co-authored-by: Carl Christian Snethlage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Citation key pattern generator should remove $ by default
4 participants