-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12536 - adding '$' to the unwanted_citation_key_characters #12796
Conversation
PR for the docs |
User facing change requires a change log entry |
@jnchin314 why is the mandatory check ticked if you didn't add a changelog entry? Did you read before ticking the rest? |
Ahh my bad. I didn't commit and push it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You put your entry in the already published part 6.0-alpha. It belongs in the unreleased part.
Fixed it |
…ref into fix-for-issue-JabRef#12536
👋 Hey! As a free user, you're receiving reviews for every 5th PR. Upgrade to get reviews on every pull request and boost your code quality! Learn more here 🚀 |
Thanks for fixing I would've moved it to the correct spot. I'll remember this for next time! |
Prefernce migration is missing! |
…bRef#12796) * JabRef#12536 - adding '$' to the unwanted_citation_key_characters as a default. * JabRef#12536 - changelog! * Update CHANGELOG.md --------- Co-authored-by: Carl Christian Snethlage <[email protected]>
…ult.
Closes #12536
I added the $ to the default unwanted_citation_key_characters
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)