Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow added for detecting changelog modification (#12783) #12807

Merged
merged 13 commits into from
Mar 24, 2025
Merged

workflow added for detecting changelog modification (#12783) #12807

merged 13 commits into from
Mar 24, 2025

Conversation

koppor
Copy link
Member

@koppor koppor commented Mar 23, 2025 •
edited
Loading

Follow-up to #12786 / #12783

Triggered by #12796 (comment)

Check sonly for [x] and then for CHANGELOG.md modificatoins - does not check for [/] and then if CHANGELOG.md is notg modified

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • [/] Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor marked this pull request as draft March 23, 2025 19:17
@koppor koppor requested a review from subhramit March 23, 2025 20:58
@koppor koppor marked this pull request as ready for review March 23, 2025 20:58
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 23, 2025 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@trag-bot Trag bot
Copy link

trag-bot bot commented Mar 23, 2025

@trag-bot didn't find any issues in the code! ✅✨

@subhramit subhramit enabled auto-merge March 23, 2025 21:39
@koppor koppor disabled auto-merge March 24, 2025 07:35
@koppor koppor merged commit 1a60a98 into main Mar 24, 2025
31 of 37 checks passed
@koppor koppor deleted the add-changelog-check branch March 24, 2025 07:35
GuilhermeRibeiroPereira pushed a commit to GuilhermeRibeiroPereira/jabref that referenced this pull request Apr 1, 2025
@koppor @palukku
@subhramit @GuilhermeRibeiroPereira
workflow added for detecting changelog modification (JabRef#12783) (J…
c3a762e 
…abRef#12807)

Co-authored-by: Philip <[email protected]>
Co-authored-by: Subhramit Basu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subhramit subhramit subhramit approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koppor @subhramit @palukku