Make run parameters explicit #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltsch
requested review from
dcoutts,
jorisdral,
mheinzel,
recursion-ninja and
wenkokke
as code owners
jorisdral
reviewed
Mar 19, 2025
Comment on lines
156
to
160
| let runParams = RunParams { | ||
| runParamCaching = CacheRunData, | ||
| runParamAlloc = RunAllocFixed 10, | ||
| runParamIndex = indexType | ||
| } |
There was a problem hiding this comment.
I was assuming we'd replace the IndexType argument to the unsafeCreateRunAt function by a RunParams
There was a problem hiding this comment.
I’m not completely sure what general picture you have in mind. I think that if we make all run parameters configurable here, we should do so also in other places. I’ve changed the code such that run parameters are now configurable in extras and only fixed in the tests and benchmarks. These changes are in 1552c8e.
There was a problem hiding this comment.
The changes you made are what I had in mind
jorisdral
approved these changes
Mar 19, 2025
Comment on lines
45
to
51
| runParams :: Index.IndexType -> RunBuilder.RunParams | ||
| runParams indexType = | ||
| RunBuilder.RunParams { | ||
| runParamCaching = RunBuilder.CacheRunData, | ||
| runParamAlloc = RunAcc.RunAllocFixed 10, | ||
| runParamIndex = indexType | ||
| } |
There was a problem hiding this comment.
Just use Index.Ordinary
jeltsch
force-pushed
the
jeltsch/no-default-run-params
branch
from
e858742 to
0cb4097
Compare
jeltsch
force-pushed
the
jeltsch/no-default-run-params
branch
from
0cb4097 to
7f0631e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes
defaultRunParamsin favor of explicit specification of run parameters.