Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish switching of index-using tests to ordinary indexes #628

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

jeltsch
Copy link
Collaborator

@jeltsch jeltsch commented Mar 15, 2025

This pull request changes the tests of various index-using modules such that these tests now use ordinary indexes instead of compact ones. #619 already made such changes to certain test modules that refer to the default table configuration. The present pull request changes test modules that specify the index type in isolation, that is, not as part of a table configuration. It modifies all such modules except for the snapshot-related ones and the main one of the state-machine-related ones.

@jeltsch jeltsch self-assigned this Mar 15, 2025
@jeltsch jeltsch requested a review from wenkokke as a code owner March 15, 2025 20:43
@jeltsch jeltsch marked this pull request as draft March 15, 2025 20:44
@jeltsch jeltsch force-pushed the jeltsch/testing-with-ordinary-indexes branch 2 times, most recently from 567f6ff to 0fff341 Compare March 18, 2025 20:02
@jeltsch jeltsch changed the base branch from main to jeltsch/no-default-run-params March 18, 2025 20:02
Copy link
Collaborator

@jorisdral jorisdral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge once #638 is done

@jeltsch jeltsch force-pushed the jeltsch/no-default-run-params branch 2 times, most recently from 0cb4097 to 7f0631e Compare March 19, 2025 17:54
Base automatically changed from jeltsch/no-default-run-params to main March 19, 2025 18:51
@jeltsch jeltsch force-pushed the jeltsch/testing-with-ordinary-indexes branch from 0fff341 to 5f38964 Compare March 20, 2025 15:48
@jeltsch jeltsch force-pushed the jeltsch/testing-with-ordinary-indexes branch from 5f38964 to 0e3e8c4 Compare March 20, 2025 15:57
@jeltsch jeltsch marked this pull request as ready for review March 20, 2025 15:59
@jeltsch jeltsch enabled auto-merge March 20, 2025 15:59
@jeltsch jeltsch added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit e6bbe63 Mar 20, 2025
27 checks passed
@jeltsch jeltsch deleted the jeltsch/testing-with-ordinary-indexes branch March 20, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants