Make ordinary indexes the default #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltsch
requested review from
mheinzel,
recursion-ninja and
wenkokke
as code owners
jorisdral
approved these changes
Mar 14, 2025
| @@ -232,7 +233,7 @@ benchInsertBatches = | |||
| !batchSize = 256 | |||
|
|
|||
| _benchConfig :: Common.TableConfig | |||
| _benchConfig = Common.defaultTableConfig { | |||
| _benchConfig = benchConfig { | |||
jorisdral
force-pushed
the
jeltsch/ordinary-indexes-as-default
branch
from
358f9d6 to
610e9b7
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now,
defaultTableConfigdeclared compact indexes to be used by default. This pull request changes this, making ordinary indexes the default.Furthermore, this pull request changes the following files such that they now override the
confFencePointerIndexfield ofdefaultTableConfigwithCompactIndexin order to continue using compact indexes:bench/macro/lsm-tree-bench-wp8.hsbench/micro/Bench/Database/LSMTree/Monoidal.hsbench/micro/Bench/Database/LSMTree/Normal.hstest/Test/Database/LSMTree/Internal/Snapshot/Codec/Golden.hstest/Test/Database/LSMTree/Internal/Snapshot/FS.hstest/Test/Database/LSMTree/UnitTests.hsThe remaining source code files that use
defaultTableConfigare the following ones:test/Test/Database/LSMTree/Class.hstest/Test/Database/LSMTree/Internal.hsThese are not changed, so that they now operate with ordinary indexes.