[E-Documents Core] - Manual multiple files import #8
Conversation
[E-Document Core] - Code workspace
Apps/W1/EDocument/app/src/Integration/EDocIntegrationManagement.Codeunit.al
Show resolved
Hide resolved
Apps/W1/EDocument/test/src/Receive/EDocReceiveManualTest.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocument/test/src/Receive/EDocReceiveManualTest.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocument/test/src/Receive/EDocReceiveManualTest.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocument/test/src/Receive/EDocReceiveManualTest.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocument/test/src/Receive/EDocReceiveManualTest.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocument/app/src/Integration/EDocIntegrationManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocument/app/src/Integration/EDocIntegrationManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
| EDocument: Record "E-Document"; | ||
| EDocGetBasicInfo: Codeunit "E-Doc. Get Basic Info"; | ||
| begin | ||
| // Commit before getting basic info with error handling (if Codeunit.Run then ) |
There was a problem hiding this comment.
No no, just one space symbol need to be removed before the last bracket :D
| EDocGetBasicInfo: Codeunit "E-Doc. Get Basic Info"; | ||
| begin | ||
| // Commit before getting basic info with error handling (if Codeunit.Run then) | ||
| Commit(); |
There was a problem hiding this comment.
I know this is from another PR, but this commit in here makes me a bit nervous. Because seeing a procedure like HasDuplicates doesn't make you think that the transaction will be commited in here...
You don't have to change anything, because I know you have other fires to fight, and I know MS is quite liberal with their commits as well, but just something to think about...
There was a problem hiding this comment.
Actually tried to avoid this commit, but happened to me while testing manually to get this error. Will keep this in my mind so if there will be some time left will try to handle this :)
|
Implementation With this update users can generate multiple incoming E-Documents when manually uploading multiple attachments from vendor documents.
The system will generate a warning message to prevent duplication. |
| CurrPage.Update(); | ||
| if EDocImport.ChooseEDocumentService(EDocumentService) then begin | ||
| EDocImport.UploadDocument(Rec, EDocumentService); | ||
| CurrPage.Update(); |
There was a problem hiding this comment.
Add explicit RunTrigger. Very recommend using false if that's enough for the solution
| PurchaseHeader.DeleteAll(false); | ||
| DocumentAttachment.DeleteAll(false); | ||
|
|
||
| EDocument.DeleteAll(); |
There was a problem hiding this comment.
EDocument.DeleteAll(true); or EDocument.DeleteAll(false);
Manual multiple files import
This pull request contains changes that make possible to upload multiple files at once if user choose to create E-Documents using manual Import Files action on E-Documents page.
MS PR: microsoft#27975