-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E-Document Core] - Skip duplicated E-Documents when receiving from service #6
base: main
Are you sure you want to change the base?
Conversation
[E-Document Core] - Code workspace
Apps/W1/EDocument/app/src/Integration/EDocIntegrationManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocument/app/src/Integration/EDocIntegrationManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocument/app/src/Integration/EDocIntegrationManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocument/app/src/Integration/EDocIntegrationManagement.Codeunit.al
Show resolved
Hide resolved
Apps/W1/EDocument/app/src/Integration/EDocIntegrationManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocument/app/src/Integration/EDocIntegrationManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocument/app/src/Integration/EDocIntegrationManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocument/app/src/Integration/EDocIntegrationManagement.Codeunit.al
Outdated
Show resolved
Hide resolved
Implementation New functionality has been added to prevent duplicate E-Documents from being created during batch imports via service import. Improvements below have been implemented:
This update reduces unnecessary processing and ensures that only unique E-documents are created even with large batches. |
@@ -235,6 +239,25 @@ codeunit 6134 "E-Doc. Integration Management" | |||
end; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why there are 2 empty lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed unneeded empty line
EDocument.SetRange("Document Date", IncomingEDocument."Document Date"); | ||
exit(not EDocument.IsEmpty()); | ||
end; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well looks like to many empty lines :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed unneeded empty lines
Implementation
New functionality has been added to prevent duplicate E-Documents from being created during batch imports via service import. Improvements below have been implemented:
The system checks for duplicates by using Vendor, External Document Number, and Document Date.
If the document in the batch matches an existing document based on criteria above, duplicate E-Document will be automatically skipped during creation.
This update reduces unnecessary processing and ensures that only unique E-documents are created even with large batches.
MS PR: microsoft#27953