Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E-Document Core] - Skip duplicated E-Documents when receiving from service #6

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

petemchlk
Copy link
Collaborator

@petemchlk petemchlk commented Jan 10, 2025

Implementation

New functionality has been added to prevent duplicate E-Documents from being created during batch imports via service import. Improvements below have been implemented:

The system checks for duplicates by using Vendor, External Document Number, and Document Date.

If the document in the batch matches an existing document based on criteria above, duplicate E-Document will be automatically skipped during creation.

This update reduces unnecessary processing and ensures that only unique E-documents are created even with large batches.

MS PR: microsoft#27953

@nerkel91
Copy link
Collaborator

nerkel91 commented Jan 15, 2025

Implementation

New functionality has been added to prevent duplicate E-Documents from being created during batch imports via service import. Improvements below have been implemented:

  • The system checks for duplicates by using Vendor, External Document Number, and Document Date.

  • If the document in the batch matches an existing document based on criteria above, duplicate E-Document will be automatically skipped during creation.

This update reduces unnecessary processing and ensures that only unique E-documents are created even with large batches.

tinestaric
tinestaric previously approved these changes Jan 16, 2025
GMatuleviciute
GMatuleviciute previously approved these changes Jan 17, 2025
@@ -235,6 +239,25 @@ codeunit 6134 "E-Doc. Integration Management"
end;

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there are 2 empty lines?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unneeded empty line

EDocument.SetRange("Document Date", IncomingEDocument."Document Date");
exit(not EDocument.IsEmpty());
end;

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well looks like to many empty lines :D

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unneeded empty lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants