Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #27: implement support for TYPO3 v10 #28

Merged
merged 10 commits into from
Apr 25, 2020
Merged

Fix #27: implement support for TYPO3 v10 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
89f58d9
Merge pull request #1 from FriendsOfTYPO3/master
dmitryd Oct 17, 2018
cc6ad89
Merge remote-tracking branch 'upstream/master'
dmitryd Nov 19, 2019
7c73e2c
[TASK] #27: add support for TYPO3 v10
dmitryd Nov 19, 2019
eebc22b
[BUGFIX] #27: valid endpoint is not returned (see https://github.com/…
dmitryd Nov 19, 2019
acab998
[TASK] #27: replace functionaly removed in TYPO3 v10 with new one
dmitryd Nov 19, 2019
084be40
[TASK] #27: in TYPO3 v10 this service has to be singleton because it …
dmitryd Nov 19, 2019
669c8ef
[TASK] #27: document php-openid extra fix in README
dmitryd Nov 21, 2019
b5470b8
[TASK] #27: use Psr logger interface & trait
dmitryd Nov 21, 2019
1a1def2
[TASK] #27: remove database creation options that cause failures with…
dmitryd Nov 21, 2019
500de81
Merge branch 'master' into feature/v10
dmitryd Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext_emconf.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
'uploadfolder' => false,
'createDirs' => '',
'clearCacheOnLoad' => false,
'version' => '8.1.1',
'version' => '10.0.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if we could make this a minor release which keeps compatibility with v8.
As far as I can see only the Environment class is the "deal breaker" here, right?

Copy link
Contributor Author

@dmitryd dmitryd Nov 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My task is to make a v10 compatible code. I do not have time allocated for anything else, sorry. I can't work on yet another base. I also cannot test if this is compatible with v8 or not: also no time allocated to it.

'constraints' => [
'depends' => [
'typo3' => '8.7.19-10.999.999',
Expand Down
2 changes: 1 addition & 1 deletion ext_tables.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ CREATE TABLE tx_openid_nonce_store (
PRIMARY KEY (uid),
UNIQUE KEY nonce (server_url(255),tstamp,salt),
KEY crdate (crdate)
) DEFAULT CHARSET = utf8 COLLATE utf8_general_ci ENGINE=InnoDB;
) ENGINE=InnoDB;
3 changes: 3 additions & 0 deletions lib/php-openid/README.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@ We use only "Auth" directory from the library and include a copy of COPYING file
Current version of the library is 3.0.1
(git-checkout c59928322ce2508094473c76c2e1c5294f97e743; # from 2020-04-07)
Source: https://github.com/openid/php-openid

Additionally copied the following bugfix to this version: https://github.com/openid/php-openid/pull/140