Fix #27: implement support for TYPO3 v10 #28
Conversation
Sync with the main repo
…is instantiated multiple times, which causes multiple requests and nonce uniqueness failure
| @@ -8,11 +8,11 @@ | |||
| 'uploadfolder' => false, | |||
| 'createDirs' => '', | |||
| 'clearCacheOnLoad' => false, | |||
| 'version' => '8.1.1', | |||
| 'version' => '10.0.0', | |||
There was a problem hiding this comment.
I would prefer if we could make this a minor release which keeps compatibility with v8.
As far as I can see only the Environment class is the "deal breaker" here, right?
There was a problem hiding this comment.
My task is to make a v10 compatible code. I do not have time allocated for anything else, sorry. I can't work on yet another base. I also cannot test if this is compatible with v8 or not: also no time allocated to it.
|
I pushed most of your changes now to master in a compatible way. Please rebase this PR if you have any additional changes. |
|
@liayn Strangely I did not have any problem with the index in the database update 😕 |
|
@dmitryd Which version of MySQL (or MariaDB) are you using? Maybe we can narrow it down somehow. I would prefer to not have the collation pre-defined in the SQL, if possible. |
|
@dmitryd So lets get that thing out of our way. Would you mind rebasing this PR on top of current master please? So whatever is left to do can be merged and released. |
|
Tested the feature branch in my TYPO3 v10 installation. No errors in upgrade wizard / database compare and login via openid works perfect. But merge conflict needs to be fixed. EDIT: I made a separate fix (see Pull Request #31) for failing database checks. Only that fix is enough for my TYPO3 installation. |
Note: this also adda a fix for a bug in the php-openid library (openid/php-openid#140)