TYPO3 v9 compatibility #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liayn
reviewed
Oct 5, 2018
| 'constraints' => [ | ||
| 'depends' => [ | ||
| 'typo3' => '8.7.0-8.7.99', | ||
| 'sv' => '8.7.0-8.7.99', |
There was a problem hiding this comment.
I guess you removed it due to not being available in v9 anymore. I still suggest adding it to the suggests section, in order to have a correct dependency chain (loading order) in v8.
It is of course not critical as core extensions are loaded first anyways.
There was a problem hiding this comment.
Also not critical because openid can be loaded in any order. It does not use anything from other extensions during TYPO3 initialisation.
There was a problem hiding this comment.
I think we can just ignore that. Otherwise it may confuse people when installing the ext in the EM.
|
Funny that the only thing that was to be adjusted, was the BACK_PATH stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the ext working onTYPO3 8.7-9.5.0.
Based on work of @florianwessels.