-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility for TYPO3 9 #22
Conversation
@@ -518,7 +521,7 @@ protected function normalizeOpenID($openIDIdentifier) | |||
*/ | |||
protected function getBackPath() | |||
{ | |||
$extPath = ExtensionManagementUtility::siteRelPath('openid'); | |||
$extPath = ExtensionManagementUtility::extPath('openid'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test this?
extPath returns an absolute path, so that will most probably not work out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ExtensionManagementUtility::siteRelPath('openid')
will returntypo3conf/ext/openid/lib/php-openid
ehm what? what's going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Append after line 524 to get the same as from siteRelPath
:
$extPath = substr($extPath, strlen(Environment::getPublicPath() . '/'));
yeah, I have tested that. |
Currently I need this ext for our 9.5.0 project, so I am updating it. I will make it compatible with both 8.7.x and 9.5.0 and will make a PR. |
Integrated in #23 |
No description provided.