Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for TYPO3 9 #22

Closed
wants to merge 5 commits into from
Closed

Add compatibility for TYPO3 9 #22

wants to merge 5 commits into from

Conversation

flossels
Copy link
Contributor

@flossels flossels commented Feb 7, 2018

No description provided.

@@ -518,7 +521,7 @@ protected function normalizeOpenID($openIDIdentifier)
*/
protected function getBackPath()
{
$extPath = ExtensionManagementUtility::siteRelPath('openid');
$extPath = ExtensionManagementUtility::extPath('openid');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this?
extPath returns an absolute path, so that will most probably not work out

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExtensionManagementUtility::siteRelPath('openid') will return typo3conf/ext/openid/lib/php-openid

ehm what? what's going on here?

Copy link
Contributor

@dmitryd dmitryd Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Append after line 524 to get the same as from siteRelPath:

$extPath = substr($extPath, strlen(Environment::getPublicPath() . '/'));

@flossels
Copy link
Contributor Author

flossels commented Feb 7, 2018

yeah, I have tested that.
ExtensionManagementUtility::siteRelPath('openid') will return typo3conf/ext/openid/lib/php-openid wich is the same result as substr(PathUtility::getAbsoluteWebPath(ExtensionManagementUtility::extPath('openid') . 'lib/php-openid'),1); both does not work.

@dmitryd
Copy link
Contributor

dmitryd commented Oct 4, 2018

Currently I need this ext for our 9.5.0 project, so I am updating it. I will make it compatible with both 8.7.x and 9.5.0 and will make a PR.

@liayn
Copy link
Member

liayn commented Oct 5, 2018

Integrated in #23

@liayn liayn closed this Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants