Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix noah nav2 #12

Open
wants to merge 5 commits into
base: humble
Choose a base branch
from

Conversation

elector102
Copy link

Noah nav2 is working! But currently without multiple robots.

You need to compile and source the project and later run:
ros2 launch noah_gazebo noah_gazebo.launch.py
and after that run:
ros2 launch noah_navigation2 navigation2.launch.py
On rviz you need to initialize the initial pose before to send a goal

@francocipollone francocipollone self-requested a review January 4, 2023 19:24
@elector102 elector102 force-pushed the elector102/fix_noah_nav branch from 9ca2ba2 to f20aa99 Compare January 25, 2023 17:04
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I left some comments, ptal.

Also:

  1. Add your new package to the ros action ci workflow so it get tested
  2. In this PR we are modifying the namespace of noah, please check that for example the noah_integration_tests is working correctly.

@@ -0,0 +1,20 @@
<?xml version="1.0"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this package being used?

Comment on lines 396 to 403
<joint name="imu_joint" type="fixed">
<parent link="front_link"/>
<child link="imu_link"/>
<origin xyz="0.0 0 0.068" rpy="0 0 0"/>
</joint>

<link name="imu_link"/>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not necessary

Comment on lines 1 to 6
# Copyright 2019 Open Source Robotics Foundation, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the license

@@ -0,0 +1,7 @@
image: map.pgm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this map which is from the turtlebot

@@ -0,0 +1,6 @@
image: rtabmap.pgm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please call it small_house so as to know what it contains

<name>noah_navigation2</name>
<version>2.1.5</version>
<description>
ROS 2 launch scripts for navigation2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focus it on Noah

ROS 2 launch scripts for navigation2
</description>
<author email="[email protected]">Fabricio Emder</author>
<maintainer email="[email protected]">Fabricio Emder</maintainer>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please add me as maintainer

<maintainer email="[email protected]">Franco Cipollone</maintainer>

use_sim_time: True
global_frame: map
robot_base_frame: base_generic_link
odom_topic: /odom
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use relative name (it will end up being at /odom as we are not adding any namespace)

Suggested change
odom_topic: /odom
odom_topic: odom


controller_server:
ros__parameters:
use_sim_time: True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok to leave them as False here and there in this file
This parameter is being overwritten by the launch file configuration -> the nav2_bringup call.

Comment on lines 135 to 136
# Add high threshold velocity for turtlebot 3 issue.
# https://github.com/ROBOTIS-GIT/turtlebot3_simulations/issues/75
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this reference to turtlebot3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants