-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix noah nav2 #12
base: humble
Are you sure you want to change the base?
Fix noah nav2 #12
Conversation
9ca2ba2
to
f20aa99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, I left some comments, ptal.
Also:
- Add your new package to the ros action ci workflow so it get tested
- In this PR we are modifying the namespace of noah, please check that for example the noah_integration_tests is working correctly.
noah_bringup/package.xml
Outdated
@@ -0,0 +1,20 @@ | |||
<?xml version="1.0"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this package being used?
<joint name="imu_joint" type="fixed"> | ||
<parent link="front_link"/> | ||
<child link="imu_link"/> | ||
<origin xyz="0.0 0 0.068" rpy="0 0 0"/> | ||
</joint> | ||
|
||
<link name="imu_link"/> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is not necessary
# Copyright 2019 Open Source Robotics Foundation, Inc. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the license
noah_navigation2/map/map.yaml
Outdated
@@ -0,0 +1,7 @@ | |||
image: map.pgm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this map which is from the turtlebot
noah_navigation2/map/rtabmap.yaml
Outdated
@@ -0,0 +1,6 @@ | |||
image: rtabmap.pgm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please call it small_house
so as to know what it contains
noah_navigation2/package.xml
Outdated
<name>noah_navigation2</name> | ||
<version>2.1.5</version> | ||
<description> | ||
ROS 2 launch scripts for navigation2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Focus it on Noah
ROS 2 launch scripts for navigation2 | ||
</description> | ||
<author email="[email protected]">Fabricio Emder</author> | ||
<maintainer email="[email protected]">Fabricio Emder</maintainer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Please add me as maintainer
<maintainer email="[email protected]">Franco Cipollone</maintainer>
noah_navigation2/param/noah.yaml
Outdated
use_sim_time: True | ||
global_frame: map | ||
robot_base_frame: base_generic_link | ||
odom_topic: /odom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Use relative name (it will end up being at /odom as we are not adding any namespace)
odom_topic: /odom | |
odom_topic: odom |
noah_navigation2/param/noah.yaml
Outdated
|
||
controller_server: | ||
ros__parameters: | ||
use_sim_time: True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ok to leave them as False
here and there in this file
This parameter is being overwritten by the launch file configuration -> the nav2_bringup call.
noah_navigation2/param/noah.yaml
Outdated
# Add high threshold velocity for turtlebot 3 issue. | ||
# https://github.com/ROBOTIS-GIT/turtlebot3_simulations/issues/75 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this reference to turtlebot3
Noah nav2 is working! But currently without multiple robots.
You need to compile and source the project and later run:
ros2 launch noah_gazebo noah_gazebo.launch.py
and after that run:
ros2 launch noah_navigation2 navigation2.launch.py
On rviz you need to initialize the initial pose before to send a goal